You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by li...@apache.org on 2025/09/10 01:19:29 UTC
(flink) branch master updated: [hotfix][table] Fix incorrect state ttl setting in KeyedLookupJoinWrapper
This is an automated email from the ASF dual-hosted git repository.
lincoln pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 551c3d7036f [hotfix][table] Fix incorrect state ttl setting in KeyedLookupJoinWrapper
551c3d7036f is described below
commit 551c3d7036fa2cfef82e5542a04d0dc98786b2b6
Author: lincoln lee <li...@gmail.com>
AuthorDate: Wed Sep 10 09:19:22 2025 +0800
[hotfix][table] Fix incorrect state ttl setting in KeyedLookupJoinWrapper
This closes #26970.
---
.../join/lookup/KeyedLookupJoinWrapper.java | 2 +-
.../operators/join/KeyedLookupJoinHarnessTest.java | 35 ++++++++++++++++++++++
2 files changed, 36 insertions(+), 1 deletion(-)
diff --git a/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/lookup/KeyedLookupJoinWrapper.java b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/lookup/KeyedLookupJoinWrapper.java
index 1164651973c..e4e106b9e3f 100644
--- a/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/lookup/KeyedLookupJoinWrapper.java
+++ b/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/lookup/KeyedLookupJoinWrapper.java
@@ -97,10 +97,10 @@ public class KeyedLookupJoinWrapper extends KeyedProcessFunction<RowData, RowDat
} else {
ValueStateDescriptor<List<RowData>> valueStateDescriptor =
new ValueStateDescriptor<>("values", new ListSerializer<>(serializer));
- state = getRuntimeContext().getState(valueStateDescriptor);
if (ttlConfig.isEnabled()) {
valueStateDescriptor.enableTimeToLive(ttlConfig);
}
+ state = getRuntimeContext().getState(valueStateDescriptor);
}
emptyRow = initEmptyRow(lookupJoinRunner.tableFieldsCount);
collectListener = new FetchedRecordListener();
diff --git a/flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/KeyedLookupJoinHarnessTest.java b/flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/KeyedLookupJoinHarnessTest.java
index 2cab5e20562..0a558250eb2 100644
--- a/flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/KeyedLookupJoinHarnessTest.java
+++ b/flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/KeyedLookupJoinHarnessTest.java
@@ -384,6 +384,41 @@ class KeyedLookupJoinHarnessTest {
testHarness.close();
}
+ @Test
+ void testTemporalLeftJoinWithTtlWithoutPk() throws Exception {
+ OneInputStreamOperatorTestHarness<RowData, RowData> testHarness =
+ createHarness(JoinType.LEFT_JOIN, FilterOnTable.WITH_FILTER, false, 1_000);
+
+ testHarness.open();
+ // set TtlTimeProvider with 1
+ testHarness.setStateTtlProcessingTime(1);
+ testHarness.processElement(insertRecord(1, "a"));
+ testHarness.processElement(insertRecord(2, "b"));
+ testHarness.processElement(insertRecord(3, "c"));
+
+ // set TtlTimeProvider with 1001 to trigger expired state cleanup
+ testHarness.setStateTtlProcessingTime(1002);
+ // should output a delete message (pad null) since it's left join
+ testHarness.processElement(deleteRecord(2, "b"));
+
+ testHarness.processElement(insertRecord(2, "b2"));
+ testHarness.processElement(updateBeforeRecord(3, "c"));
+ testHarness.processElement(updateAfterRecord(3, "c2"));
+
+ List<Object> expectedOutput = new ArrayList<>();
+ expectedOutput.add(insertRecord(1, "a", 1, "Julian"));
+ expectedOutput.add(insertRecord(2, "b", null, null));
+ expectedOutput.add(insertRecord(3, "c", 3, "Jackson"));
+ expectedOutput.add(deleteRecord(2, "b", null, null));
+ expectedOutput.add(insertRecord(2, "b2", 2, "default-2"));
+ expectedOutput.add(deleteRecord(3, "c", null, null));
+ expectedOutput.add(insertRecord(3, "c2", 6, "Jark-2"));
+ expectedOutput.add(insertRecord(3, "c2", 6, "Jackson-2"));
+
+ assertor.assertOutputEquals("output wrong.", expectedOutput, testHarness.getOutput());
+ testHarness.close();
+ }
+
@Test
void testTemporalInnerJoinWithTtlLookupKeyContainsPk() throws Exception {
OneInputStreamOperatorTestHarness<RowData, RowData> testHarness =