You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/04/18 20:12:06 UTC

Review Request 46338: AMBARI-15949 Tweaks to Alerts hyperlink display

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46338/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15949
    https://issues.apache.org/jira/browse/AMBARI-15949


Repository: ambari


Description
-------

Change the way the hyperlink to an external alert detail URL is shown.


Diffs
-----

  ambari-web/app/messages.js 8d73bb3 
  ambari-web/app/templates/main/alerts/configs.hbs 4259be8 
  ambari-web/app/templates/main/alerts/definition_details.hbs 15cf168 

Diff: https://reviews.apache.org/r/46338/diff/


Testing
-------

Local ambari-web test passed.
25681 tests complete (23 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang


Re: Review Request 46338: AMBARI-15949 Tweaks to Alerts hyperlink display

Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46338/#review129406
-----------------------------------------------------------


Ship it!




Ship It!

- Richard Zang


On April 18, 2016, 6:12 p.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46338/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 6:12 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15949
>     https://issues.apache.org/jira/browse/AMBARI-15949
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change the way the hyperlink to an external alert detail URL is shown.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js 8d73bb3 
>   ambari-web/app/templates/main/alerts/configs.hbs 4259be8 
>   ambari-web/app/templates/main/alerts/definition_details.hbs 15cf168 
> 
> Diff: https://reviews.apache.org/r/46338/diff/
> 
> 
> Testing
> -------
> 
> Local ambari-web test passed.
> 25681 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>