You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/03 12:25:45 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #205: [YUNIKORN-326]Add rest API to retrieve cluster nodes resource utilization
codecov[bot] edited a comment on pull request #205:
URL: https://github.com/apache/incubator-yunikorn-core/pull/205#issuecomment-691490208
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205?src=pr&el=h1) Report
> Merging [#205](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/c2699e725c8a0f89fbcd7618908ad4cf712227e9?el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 61.24% 60.89% -0.35%
==========================================
Files 67 67
Lines 6618 5723 -895
==========================================
- Hits 4053 3485 -568
+ Misses 2420 2097 -323
+ Partials 145 141 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/cachetestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NhY2hldGVzdHV0aWxzLmdv) | `51.51% <0.00%> (+1.51%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `51.17% <75.75%> (+2.95%)` | :arrow_up: |
| [pkg/common/configs/configtestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3Rlc3R1dGlscy5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| [pkg/metrics/metrics\_collector.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL21ldHJpY3MvbWV0cmljc19jb2xsZWN0b3IuZ28=) | `73.91% <0.00%> (-4.66%)` | :arrow_down: |
| [pkg/scheduler/scheduling\_allocation\_ask.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsaW5nX2FsbG9jYXRpb25fYXNrLmdv) | `54.05% <0.00%> (-4.09%)` | :arrow_down: |
| [pkg/common/configs/config.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZy5nbw==) | `68.96% <0.00%> (-2.91%)` | :arrow_down: |
| [pkg/log/logger.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `80.00% <0.00%> (-2.50%)` | :arrow_down: |
| [pkg/cache/initializer.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2luaXRpYWxpemVyLmdv) | `78.82% <0.00%> (-2.43%)` | :arrow_down: |
| [pkg/plugins/plugins.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbnMvcGx1Z2lucy5nbw==) | `72.72% <0.00%> (-2.28%)` | :arrow_down: |
| [pkg/common/security/acl.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9zZWN1cml0eS9hY2wuZ28=) | `83.33% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [59 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205?src=pr&el=footer). Last update [c2699e7...fb16cad](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/205?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org