You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/05/08 08:56:57 UTC

Review Request 59044: AMBARI-20952. Collection added to itself

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59044/
-----------------------------------------------------------

Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sebastian Toader.


Bugs: AMBARI-20952
    https://issues.apache.org/jira/browse/AMBARI-20952


Repository: ambari


Description
-------

Fix typo


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java c879c021bea98b034a6351d2f139670510d21b2b 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 72d3bd367a5f1d0eb4ba0532ecb41abe237e8f53 
  ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java f6b7dfa504f6e8743d760dfaa1edd37d2dbef680 
  ambari-server/src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java ec89a8c022089535ea4298c7d495c6f6cf177456 


Diff: https://reviews.apache.org/r/59044/diff/1/


Testing
-------

New unit test


Thanks,

Attila Doroszlai


Re: Review Request 59044: AMBARI-20952. Collection added to itself

Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59044/#review174145
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On May 8, 2017, 10:56 a.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59044/
> -----------------------------------------------------------
> 
> (Updated May 8, 2017, 10:56 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20952
>     https://issues.apache.org/jira/browse/AMBARI-20952
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix typo
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java c879c021bea98b034a6351d2f139670510d21b2b 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 72d3bd367a5f1d0eb4ba0532ecb41abe237e8f53 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java f6b7dfa504f6e8743d760dfaa1edd37d2dbef680 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java ec89a8c022089535ea4298c7d495c6f6cf177456 
> 
> 
> Diff: https://reviews.apache.org/r/59044/diff/1/
> 
> 
> Testing
> -------
> 
> New unit test
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>


Re: Review Request 59044: AMBARI-20952. Collection added to itself

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59044/#review174181
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On May 8, 2017, 8:56 a.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59044/
> -----------------------------------------------------------
> 
> (Updated May 8, 2017, 8:56 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Oliver Szabo, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20952
>     https://issues.apache.org/jira/browse/AMBARI-20952
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix typo
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/QuickLinksConfigurationModule.java c879c021bea98b034a6351d2f139670510d21b2b 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/ThemeModule.java 72d3bd367a5f1d0eb4ba0532ecb41abe237e8f53 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java f6b7dfa504f6e8743d760dfaa1edd37d2dbef680 
>   ambari-server/src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java ec89a8c022089535ea4298c7d495c6f6cf177456 
> 
> 
> Diff: https://reviews.apache.org/r/59044/diff/1/
> 
> 
> Testing
> -------
> 
> New unit test
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>