You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by qi...@apache.org on 2021/06/07 10:57:03 UTC
[iotdb] branch rel/0.12 updated: Fix compaction lock with query
(#3366)
This is an automated email from the ASF dual-hosted git repository.
qiaojialin pushed a commit to branch rel/0.12
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/rel/0.12 by this push:
new a06b91c Fix compaction lock with query (#3366)
a06b91c is described below
commit a06b91c46eec94973a17c77d8bf5b44a45aa51a0
Author: Jackie Tien <Ja...@foxmail.com>
AuthorDate: Mon Jun 7 18:56:36 2021 +0800
Fix compaction lock with query (#3366)
---
.../java/org/apache/iotdb/db/engine/compaction/TsFileManagement.java | 4 ++--
.../apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileManagement.java b/server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileManagement.java
index 4ae9f1f..8dc2e16 100644
--- a/server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileManagement.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/compaction/TsFileManagement.java
@@ -135,11 +135,11 @@ public abstract class TsFileManagement {
/** fork current TsFile list (call this before merge) */
public abstract void forkCurrentFileList(long timePartition) throws IOException;
- protected void readLock() {
+ public void readLock() {
compactionMergeLock.readLock().lock();
}
- protected void readUnLock() {
+ public void readUnLock() {
compactionMergeLock.readLock().unlock();
}
diff --git a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
index 8beca06..b2d4b60 100755
--- a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java
@@ -1587,10 +1587,14 @@ public class StorageGroupProcessor {
}
public void readLock() {
+ // apply read lock for SG insert lock to prevent inconsistent with concurrently writing memtable
insertLock.readLock().lock();
+ // apply read lock for TsFileResource list
+ tsFileManagement.readLock();
}
public void readUnlock() {
+ tsFileManagement.readUnLock();
insertLock.readLock().unlock();
}