You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 13:26:45 UTC

[GitHub] [superset] geido opened a new pull request #13276: test: Add tests for ErrorBoundary component and dedicated directory

geido opened a new pull request #13276:
URL: https://github.com/apache/superset/pull/13276


   ### SUMMARY
   This PR adds the tests for the ErrorBoundary component while moving it to its own dedicated directory.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas merged pull request #13276: test: ErrorBoundary dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13276:
URL: https://github.com/apache/superset/pull/13276


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on a change in pull request #13276: test: ErrorBoundary dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #13276:
URL: https://github.com/apache/superset/pull/13276#discussion_r583803657



##########
File path: superset-frontend/src/components/ErrorBoundary/index.jsx
##########
@@ -19,7 +19,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import { t } from '@superset-ui/core';
-import ErrorMessageWithStackTrace from './ErrorMessage/ErrorMessageWithStackTrace';
+import ErrorMessageWithStackTrace from '../ErrorMessage/ErrorMessageWithStackTrace';

Review comment:
       nit: prefer absolute import unless it's `./`

##########
File path: superset-frontend/src/components/ErrorBoundary/index.jsx
##########
@@ -19,7 +19,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import { t } from '@superset-ui/core';
-import ErrorMessageWithStackTrace from './ErrorMessage/ErrorMessageWithStackTrace';
+import ErrorMessageWithStackTrace from '../ErrorMessage/ErrorMessageWithStackTrace';

Review comment:
       nit: prefer absolute import unless it's `./`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido closed pull request #13276: test: ErrorBoundary dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
geido closed pull request #13276:
URL: https://github.com/apache/superset/pull/13276


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #13276: test: ErrorBoundary dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13276:
URL: https://github.com/apache/superset/pull/13276#issuecomment-788102269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=h1) Report
   > Merging [#13276](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=desc) (21f0378) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `0.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13276/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13276      +/-   ##
   ==========================================
   + Coverage   72.29%   73.14%   +0.84%     
   ==========================================
     Files         864      566     -298     
     Lines       44883    20638   -24245     
     Branches     5403     5403              
   ==========================================
   - Hits        32450    15096   -17354     
   + Misses      12224     5418    -6806     
   + Partials      209      124      -85     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `58.54% <ø> (?)` | |
   | javascript | `62.46% <ø> (+0.21%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/components/ErrorBoundary/index.jsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JCb3VuZGFyeS9pbmRleC5qc3g=) | `95.45% <ø> (ø)` | |
   | [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (-6.82%)` | :arrow_down: |
   | [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `76.00% <0.00%> (-3.17%)` | :arrow_down: |
   | [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `84.33% <0.00%> (-1.03%)` | :arrow_down: |
   | [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `62.50% <0.00%> (-0.66%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `68.98% <0.00%> (-0.33%)` | :arrow_down: |
   | [.../src/components/dataViewCommon/TableCollection.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvZGF0YVZpZXdDb21tb24vVGFibGVDb2xsZWN0aW9uLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | | |
   | [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | | |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | | |
   | ... and [503 more](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=footer). Last update [9b5e66b...2c06e03](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #13276: test: ErrorBoundary dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13276:
URL: https://github.com/apache/superset/pull/13276#issuecomment-788102269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=h1) Report
   > Merging [#13276](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=desc) (5efc2f1) into [master](https://codecov.io/gh/apache/superset/commit/9b5e66b728190e0dde5e6ddfb0f018cbdd8e5283?el=desc) (9b5e66b) will **increase** coverage by `0.68%`.
   > The diff coverage is `62.13%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13276/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13276      +/-   ##
   ==========================================
   + Coverage   72.29%   72.98%   +0.68%     
   ==========================================
     Files         864      598     -266     
     Lines       44883    21266   -23617     
     Branches     5403     5498      +95     
   ==========================================
   - Hits        32450    15521   -16929     
   + Misses      12224     5618    -6606     
   + Partials      209      127      -82     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `57.65% <33.94%> (?)` | |
   | javascript | `62.79% <59.02%> (+0.54%)` | :arrow_up: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.15% <0.00%> (+20.29%)` | :arrow_up: |
   | [...rc/common/components/Collapse/Collapse.stories.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL0NvbGxhcHNlLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
   | [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...set-frontend/src/common/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsL01vZGFsLnRzeA==) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...mponents/AsyncAceEditor/AsyncAceEditor.stories.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvQXN5bmNBY2VFZGl0b3Iuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
   | [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `87.75% <ø> (ø)` | |
   | [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `96.29% <ø> (ø)` | |
   | [...rset-frontend/src/components/DeleteModal/index.tsx](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
   | ... and [627 more](https://codecov.io/gh/apache/superset/pull/13276/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=footer). Last update [9b5e66b...2c06e03](https://codecov.io/gh/apache/superset/pull/13276?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #13276: test: ErrorBoundary dedicated directory and tests

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13276:
URL: https://github.com/apache/superset/pull/13276#issuecomment-783861686


   Thank you @geido for adding test to this component, which previously have no test coverage at all. 🙏 🙂


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org