[jira] Updated: (HBASE-584) Names in the filter interface are confusing

["Clint Morgan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Clint Morgan updated HBASE-584:
-------------------------------

    Attachment: hbase-584.patch

I don't see the need to backport this. It just a renaming on interface methods, and backporting could break existing 3rd party filters.

Attached is a simple renaming patch as discussed.

It also contains a slight rework of RowFilterSet to use ObjectWritable for serialization of the filters. This results in cleaner code, and moreover I hit a snag where this code would barf due to non-public constructor, where ObjectWritable will handle corectly.

> Names in the filter interface are confusing
> -------------------------------------------
>
>                 Key: HBASE-584
>                 URL: https://issues.apache.org/jira/browse/HBASE-584
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Clint Morgan
>            Priority: Minor
>         Attachments: hbase-584.patch
>
>
> I don't like the names of the filter methods in RowFilterInterface. They don't really tell how the methods are being used in the implementation of scanners.
> I'd like to change:
>  - filter(Text) to filterRow(...)
>  - filter(Text, Text, byte[]) to filterColumn(...)
>   and the worst one is
>  - filterNotNull(SortedMap<Text, byte[]>). This should be filterRow(Text, SortedMap<Text, byte[]>) (so we add the row key/).
> It may be nice to have timestamps in the methods as well? 
> Also the java doc could be cleaned and improved to tell how the filtering is implemented (check rows keys first, then check each individual columns, finally check the assembled row)
> Upon positive feedback, and I'll create a patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.