You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2017/12/26 07:54:15 UTC
[GitHub] codecov-io commented on issue #224: SCB-127 The consumer micro-service can discovery SC instances.
codecov-io commented on issue #224: SCB-127 The consumer micro-service can discovery SC instances.
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/224#issuecomment-353934334
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224?src=pr&el=h1) Report
> Merging [#224](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/d634534939868aa93b85493183c13faada2033c1?src=pr&el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `64.7%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 67.99% 68.85% +0.85%
==========================================
Files 17 17
Lines 3584 3554 -30
==========================================
+ Hits 2437 2447 +10
+ Misses 974 934 -40
Partials 173 173
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224?src=pr&el=tree) | Coverage ? | |
|---|---|---|
| [server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==) | `73.42% <100%> (?)` | :arrow_up: |
| [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `49.71% <50%> (?)` | :arrow_up: |
| [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `68.66% <60%> (+0.85%)` | :arrow_up: |
| [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `53.79% <60.9%> (+3.66%)` | :arrow_up: |
| [server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv) | `75% <72%> (-1.53%)` | :arrow_down: |
| [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `70.63% <75%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224?src=pr&el=footer). Last update [d634534...6f23afe](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/224?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services