You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2013/12/06 05:08:49 UTC
Re: git commit: TS-2420: Remove STAT_SYNC, CONF_SYNC, and REM_SYNC threads and schedule those continuations in ET_TASK
On Dec 5, 2013, at 8:25 PM, sorber@apache.org wrote:
> Updated Branches:
> refs/heads/master 354fbc267 -> 853722820
>
>
> TS-2420: Remove STAT_SYNC, CONF_SYNC, and REM_SYNC threads and schedule
> those continuations in ET_TASK
I think with this, we should make the proxy.config.task_threads be a minimum of 1. E.g.
diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
index a54e018..ca805db 100644
--- a/mgmt/RecordsConfig.cc
+++ b/mgmt/RecordsConfig.cc
@@ -114,7 +114,7 @@ RecordElement RecordsConfig[] = {
,
{RECT_CONFIG, "proxy.config.accept_threads", RECD_INT, "1", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_READ_ONLY}
,
- {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-99999]", RECA_READ_ONLY}
+ {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2", RECU_RESTART_TS, RR_NULL, RECC_INT, "[1-99999]", RECA_READ_ONLY}
,
{RECT_CONFIG, "proxy.config.thread.default.stacksize", RECD_INT, "1048576", RECU_RESTART_TS, RR_NULL, RECC_INT, "[131072-104857600]", RECA_READ_ONLY}
,
Granted, I don’t think we do much (anything?) with the validations right now, but we should :).
— Leif
Re: git commit: TS-2420: Remove STAT_SYNC, CONF_SYNC, and REM_SYNC
threads and schedule those continuations in ET_TASK
Posted by Phil Sorber <so...@apache.org>.
On Thu, Dec 5, 2013 at 9:08 PM, Leif Hedstrom <zw...@apache.org> wrote:
>
> On Dec 5, 2013, at 8:25 PM, sorber@apache.org wrote:
>
> > Updated Branches:
> > refs/heads/master 354fbc267 -> 853722820
> >
> >
> > TS-2420: Remove STAT_SYNC, CONF_SYNC, and REM_SYNC threads and schedule
> > those continuations in ET_TASK
>
>
>
> I think with this, we should make the proxy.config.task_threads be a
> minimum of 1. E.g.
>
>
I concur. Is this a compatible change?
> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
> index a54e018..ca805db 100644
> --- a/mgmt/RecordsConfig.cc
> +++ b/mgmt/RecordsConfig.cc
> @@ -114,7 +114,7 @@ RecordElement RecordsConfig[] = {
> ,
> {RECT_CONFIG, "proxy.config.accept_threads", RECD_INT, "1",
> RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_READ_ONLY}
> ,
> - {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2",
> RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-99999]", RECA_READ_ONLY}
> + {RECT_CONFIG, "proxy.config.task_threads", RECD_INT, "2",
> RECU_RESTART_TS, RR_NULL, RECC_INT, "[1-99999]", RECA_READ_ONLY}
> ,
> {RECT_CONFIG, "proxy.config.thread.default.stacksize", RECD_INT,
> "1048576", RECU_RESTART_TS, RR_NULL, RECC_INT, "[131072-104857600]",
> RECA_READ_ONLY}
> ,
>
>
>
> Granted, I don’t think we do much (anything?) with the validations right
> now, but we should :).
>
>
Even if this does nothing, it should be trivial to put in a check somewhere
until validations can be fixed completely. Is there a bug open for that?
All I see is TS-1992.
> — Leif
>
>