You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/07/29 14:39:40 UTC
Review Request 13014: CLOUDSTACK-3841: Fixed
TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
The exception raised is valid behavior. It attempts to delete security group without destroying vm in it, hence expecting exception in the operation.
Added self.assertRaises for the security group delete operation. Works fin now.
Diffs
-----
test/integration/component/test_security_groups.py 3c25e25
Diff: https://reviews.apache.org/r/13014/diff/
Testing
-------
Tested on KVM basic setup.
Thanks,
Gaurav Aradhye
Re: Review Request 13014: CLOUDSTACK-3841: Fixed
TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24132
-----------------------------------------------------------
Review 13014 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #70 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/70/
- Jenkins Cloudstack.org
On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 12:39 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The exception raised is valid behavior. It attempts to delete security group without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin now.
>
>
> Diffs
> -----
>
> test/integration/component/test_security_groups.py 3c25e25
>
> Diff: https://reviews.apache.org/r/13014/diff/
>
>
> Testing
> -------
>
> Tested on KVM basic setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 13014: CLOUDSTACK-3841: Fixed
TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24125
-----------------------------------------------------------
Commit 67c96d419d08f5a2702eee0aa64958e486f74703 in branch refs/heads/4.2 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=67c96d4 ]
CLOUDSTACK-3841: Fixed test case issue. The exception raised earlier was valid behaviour, added missing assertRaiss statement
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 12:39 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The exception raised is valid behavior. It attempts to delete security group without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin now.
>
>
> Diffs
> -----
>
> test/integration/component/test_security_groups.py 3c25e25
>
> Diff: https://reviews.apache.org/r/13014/diff/
>
>
> Testing
> -------
>
> Tested on KVM basic setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 13014: CLOUDSTACK-3841: Fixed
TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24124
-----------------------------------------------------------
Commit 3a3145507d8b68b13d4320847511aaacc25475e5 in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3a31455 ]
CLOUDSTACK-3841: Fixed test case issue. The exception raised earlier was valid behaviour, added missing assertRaiss statement
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 67c96d419d08f5a2702eee0aa64958e486f74703)
- ASF Subversion and Git Services
On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 12:39 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The exception raised is valid behavior. It attempts to delete security group without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin now.
>
>
> Diffs
> -----
>
> test/integration/component/test_security_groups.py 3c25e25
>
> Diff: https://reviews.apache.org/r/13014/diff/
>
>
> Testing
> -------
>
> Tested on KVM basic setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 13014: CLOUDSTACK-3841: Fixed
TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13014/#review24126
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanna Santhanam
On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13014/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 12:39 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The exception raised is valid behavior. It attempts to delete security group without destroying vm in it, hence expecting exception in the operation.
> Added self.assertRaises for the security group delete operation. Works fin now.
>
>
> Diffs
> -----
>
> test/integration/component/test_security_groups.py 3c25e25
>
> Diff: https://reviews.apache.org/r/13014/diff/
>
>
> Testing
> -------
>
> Tested on KVM basic setup.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>