You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/27 09:44:13 UTC

[GitHub] [incubator-nuttx] yamt commented on pull request #2419: Syslog and nxstyle fixes

yamt commented on pull request #2419:
URL: https://github.com/apache/incubator-nuttx/pull/2419#issuecomment-734744573


   The following nxstyle errors are known. I'm not going to fix them in this PR.
   
   * Constants definitions like TPM_CnSC_MSB.
   
   arch/arm/src/kl/kl_pwm.c:438:44: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:438:59: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:445:44: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:445:59: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:452:44: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:452:59: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:459:44: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:459:59: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:466:44: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:466:59: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:473:44: error: Mixed case identifier found
   arch/arm/src/kl/kl_pwm.c:473:59: error: Mixed case identifier found
   
   * A table, not trivial to fix:
   
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:142:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:143:95: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:144:88: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:145:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:146:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:147:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:148:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:149:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:150:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:151:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:152:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:153:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:154:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:155:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:156:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:157:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:158:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:159:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:160:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:161:119: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:162:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:163:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:164:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:165:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:166:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:167:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:168:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:169:108: error: Long line found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:170:119: error: Long line found
   
   * Identifiers like ASCII_a:
   
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:397:35: error: Mixed case identifier found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:651:16: error: Mixed case identifier found
   boards/arm/stm32/stm32ldiscovery/src/stm32_lcd.c:660:38: error: Mixed case identifier found


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org