You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (Created) (JIRA)" <ji...@apache.org> on 2012/03/01 01:09:57 UTC

[jira] [Created] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Remove the deprecated Syncable.sync() method
--------------------------------------------

                 Key: HADOOP-8124
                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
             Project: Hadoop Common
          Issue Type: Improvement
          Components: fs
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Tsz Wo (Nicholas), SZE


The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220952#comment-13220952 ] 

Hudson commented on HADOOP-8124:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1007 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1007/])
    HADOOP-8124, HDFS-3034, MAPREDUCE-3956. Remove the deprecated Syncable.sync(). (Revision 1295999)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295999
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStream.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Syncable.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java

                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.24.0
>
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8124:
-------------------------------------------

    Hadoop Flags: Incompatible change
    
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220505#comment-13220505 ] 

Hudson commented on HADOOP-8124:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1892 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1892/])
    HADOOP-8124, HDFS-3034, MAPREDUCE-3956. Remove the deprecated Syncable.sync(). (Revision 1295999)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295999
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStream.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Syncable.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java

                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.24.0
>
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8124:
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.24.0
     Release Note: Remove the deprecated FSDataOutputStream constructor, FSDataOutputStream.sync() and Syncable.sync().  
     Hadoop Flags: Incompatible change,Reviewed  (was: Incompatible change)
           Status: Resolved  (was: Patch Available)

I have committed this.
                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.24.0
>
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219682#comment-13219682 ] 

Hadoop QA commented on HADOOP-8124:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12516624/c8124_20120229.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/647//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/647//console

This message is automatically generated.
                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220542#comment-13220542 ] 

Hudson commented on HADOOP-8124:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1825 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1825/])
    HADOOP-8124, HDFS-3034, MAPREDUCE-3956. Remove the deprecated Syncable.sync(). (Revision 1295999)

     Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295999
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStream.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Syncable.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java

                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.24.0
>
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219757#comment-13219757 ] 

Suresh Srinivas commented on HADOOP-8124:
-----------------------------------------

+1 for the patch.
                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220511#comment-13220511 ] 

Hudson commented on HADOOP-8124:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #1818 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1818/])
    HADOOP-8124, HDFS-3034, MAPREDUCE-3956. Remove the deprecated Syncable.sync(). (Revision 1295999)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295999
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStream.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Syncable.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java

                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.24.0
>
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8124:
-------------------------------------------

    Status: Patch Available  (was: Open)
    
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220889#comment-13220889 ] 

Hudson commented on HADOOP-8124:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #972 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/972/])
    HADOOP-8124, HDFS-3034, MAPREDUCE-3956. Remove the deprecated Syncable.sync(). (Revision 1295999)

     Result = UNSTABLE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1295999
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSDataOutputStream.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Syncable.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraOutputFormat.java

                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.24.0
>
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8124) Remove the deprecated Syncable.sync() method

Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-8124:
-------------------------------------------

    Attachment: c8124_20120229.patch

c8124_20120229.patch:

- removes Syncable.sync();
- removes the deprecated FSDataOutputStream(out);
- removes unnecessary "throws IOException" declarations.
                
> Remove the deprecated Syncable.sync() method
> --------------------------------------------
>
>                 Key: HADOOP-8124
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8124
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: c8124_20120229.patch
>
>
> The Syncable.sync() was deprecated in 0.21.  We should remove it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira