[jira] Commented: (THRIFT-74) Thrift::Socket.new should accept optional timeout argument

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612723#action_12612723 ] 

David Reiss commented on THRIFT-74:
-----------------------------------

I think this works better as a property (or getter/setter) than a constructor argument, though I don't know Ruby so maybe it is already a public member and I just can't tell :).  Also, remember that you also have to set timeouts on connect and send in order to be able to make any guarantees.

> Thrift::Socket.new should accept optional timeout argument
> ----------------------------------------------------------
>
>                 Key: THRIFT-74
>                 URL: https://issues.apache.org/jira/browse/THRIFT-74
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (Ruby)
>            Reporter: Kevin Ballard
>            Priority: Minor
>         Attachments: 0001-rb-Add-optional-timeout-argument-to-Thrift-Socket.patch, 0001-rb-Add-optional-timeout-argument-to-Thrift-Socket.patch
>
>
> Thrift::Socket.new should accept an optional timeout argument which will raise an TransportException if no data was returned during a #read in that time period.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.