You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/09 17:27:16 UTC

[GitHub] [pulsar] bharanic-dev commented on pull request #11601: [Issue 11096][Tests] Attempt to fix flaky test ResourceGroupConfigListenerTest

bharanic-dev commented on pull request #11601:
URL: https://github.com/apache/pulsar/pull/11601#issuecomment-895404010


   @lhotari thank you for making the changes. The changes look good to me in general and I think they are in the right direction. But I am not sure it explains the failure in the test case. The real issue is that with the metadata-store implementation, there is a race condition that can result in ZK the watch events getting missed. I filed the following issue for it, also explaining the cases where the race condition can happen. 
   
   https://github.com/apache/pulsar/pull/11157
   
   I discussed this with @merlimat. @merlimat  has a PR to address the issue, but it is not yet merged.
   
   https://github.com/apache/pulsar/pull/11198
   
   Your changes will likely not fix the problem, but change the timing such that it is difficult to get the race condition to happen. I suggest we wait for the above PR to be merged before we merge the changes you did to the test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org