[GitHub] [jmeter] PoojaChandak opened a new pull request #612: Update README.md

[GitBox <gi...@apache.org>]

PoojaChandak opened a new pull request #612:
URL: https://github.com/apache/jmeter/pull/612


   Observed a few changes. Suggesting the same. Kindly check.
   
   ## Description
   <!--- Provide a general summary of your changes in the Title above -->
   <!--- Describe your changes in detail here -->
   
   ## Motivation and Context
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ## How Has This Been Tested?
   <!--- Please describe in detail how you tested your changes. -->
   <!--- Include details of your testing environment, tests ran to see how -->
   <!--- your change affects other areas of the code, etc. -->
   
   ## Screenshots (if appropriate):
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate -->
   - Bug fix (non-breaking change which fixes an issue)
   - New feature (non-breaking change which adds functionality)
   - Breaking change (fix or feature that would cause existing functionality to not work as expected)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [ ] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on a change in pull request #612: Update README.md

[GitBox <gi...@apache.org>]

FSchumacher commented on a change in pull request #612:
URL: https://github.com/apache/jmeter/pull/612#discussion_r473031551



##########
File path: README.md
##########
@@ -247,7 +247,7 @@ Export Administration Regulations, Section 740.13) for both object
 code and source code.
 
 The following provides more details on the included software that
-may be subject to export controls on cryptographic software:
+maybe subject to export controls on cryptographic software:

Review comment:
       I am pretty sure, that `may be` is correct here.

##########
File path: README.md
##########
@@ -79,7 +79,7 @@ Easy correlation through ability to extract data from most popular response form
 - Several load statistics can be chosen with **pluggable tiers**.
 - Data analysis and **visualization plugins** allow great extensibility and personalization.
 - Functions can be used to provide dynamic input to a test or provide data manipulation.
-- Easy Continuous Integration via 3rd party Open Source libraries for Maven, Gradle and Jenkins.
+- Easy Continuous Integration via 3rd party Open Source libraries for Maven, Gradle, and Jenkins.

Review comment:
       Have you had a look at all the other places, where we don't follow the rule to place a comma before `and` when spelling out lists?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org