You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 04:03:15 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #2884: feat: server info

spacewander commented on a change in pull request #2884:
URL: https://github.com/apache/apisix/pull/2884#discussion_r533059031



##########
File path: apisix/admin/init.lua
##########
@@ -316,6 +330,11 @@ local uri_route = {
         methods = {"PUT"},
         handler = post_reload_plugins,
     },
+    {
+        paths = [[/apisix/admin/server_info]],

Review comment:
       @membphis @tokers 
   The API should go to the control API: https://github.com/apache/apisix/issues/2798.
   There is security risk if we put this feature into a plugin. Like the prometheus metrics, we don't have a default way to protect them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org