You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/13 13:45:38 UTC
Re: Review Request 68296: Add 'handler' field to batched state
requests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/
-----------------------------------------------------------
(Updated Aug. 13, 2018, 1:45 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Summary (updated)
-----------------
Add 'handler' field to batched state requests.
Repository: mesos
Description (updated)
-------
Add 'handler' field to batched state requests.
Diffs (updated)
-----
src/master/http.cpp d43fbd689598612ec5946b46e2fa5e7f5e22cfa8
src/master/master.hpp 209b998db8d2bad7a3812df44f0939458f48eb11
src/master/master.cpp 21de9739d2891c96cd036621e3f87a160c1d7c30
Diff: https://reviews.apache.org/r/68296/diff/2/
Changes: https://reviews.apache.org/r/68296/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/#review207409
-----------------------------------------------------------
src/master/http.cpp
Line 3032 (original), 3033 (patched)
<https://reviews.apache.org/r/68296/#comment290799>
Let's keep associate.
- Alexander Rukletsov
On Aug. 14, 2018, 2:20 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68296/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 2:20 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds a handler field to be able to batch
> arbitrary requests, instead of having a hard-coded
> dispatch to `state`.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68296/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/#review207649
-----------------------------------------------------------
Fix it, then Ship it!
src/master/http.cpp
Line 2861 (original), 2865 (patched)
<https://reviews.apache.org/r/68296/#comment291085>
I think we don't add a space between the variable name and c-tor initialization list.
- Alexander Rukletsov
On Aug. 20, 2018, 2:11 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68296/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 2:11 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds a handler field to be able to batch
> arbitrary requests, instead of having a hard-coded
> dispatch to `state`.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3
>
>
> Diff: https://reviews.apache.org/r/68296/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 6:45 a.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
This commit adds a handler field to be able to batch
arbitrary requests, instead of having a hard-coded
dispatch to `state`.
Diffs
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3
Diff: https://reviews.apache.org/r/68296/diff/8/
Testing (updated)
-------
`make check` on various Linux distros.
Thanks,
Benno Evers
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/
-----------------------------------------------------------
(Updated Aug. 20, 2018, 2:11 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Changes
-------
Cosmetic changes.
Repository: mesos
Description
-------
This commit adds a handler field to be able to batch
arbitrary requests, instead of having a hard-coded
dispatch to `state`.
Diffs (updated)
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3
Diff: https://reviews.apache.org/r/68296/diff/7/
Changes: https://reviews.apache.org/r/68296/diff/6-7/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/#review207533
-----------------------------------------------------------
Ship it!
Looks like a clean approach, thanks!
- Benjamin Mahler
On Aug. 17, 2018, 7:04 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68296/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:04 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds a handler field to be able to batch
> arbitrary requests, instead of having a hard-coded
> dispatch to `state`.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68296/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Benno Evers <be...@mesosphere.com>.
> On Aug. 20, 2018, 9:51 a.m., Alexander Rukletsov wrote:
> > src/master/http.cpp
> > Line 3031 (original), 3035-3036 (patched)
> > <https://reviews.apache.org/r/68296/diff/6/?file=2074729#file2074729line3035>
> >
> > These will become `const &`.
Huh, weird, this looks like another reviewboard-bug - it's changed to `const &` in the dependent review `r/68343` yet this one show "no change" but also doesn't show the correct state of this line.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/#review207606
-----------------------------------------------------------
On Aug. 20, 2018, 2:11 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68296/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 2:11 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds a handler field to be able to batch
> arbitrary requests, instead of having a hard-coded
> dispatch to `state`.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 36994a18a8e9092c0a46834f56ce3d9448e2bca3
>
>
> Diff: https://reviews.apache.org/r/68296/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/#review207606
-----------------------------------------------------------
Fix it, then Ship it!
src/master/http.cpp
Line 3031 (original), 3035-3036 (patched)
<https://reviews.apache.org/r/68296/#comment291060>
These will become `const &`.
src/master/master.hpp
Lines 1871 (patched)
<https://reviews.apache.org/r/68296/#comment291059>
Remove this blank line
- Alexander Rukletsov
On Aug. 17, 2018, 7:04 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68296/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 7:04 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds a handler field to be able to batch
> arbitrary requests, instead of having a hard-coded
> dispatch to `state`.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
>
>
> Diff: https://reviews.apache.org/r/68296/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 7:04 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Repository: mesos
Description
-------
This commit adds a handler field to be able to batch
arbitrary requests, instead of having a hard-coded
dispatch to `state`.
Diffs (updated)
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68296/diff/6/
Changes: https://reviews.apache.org/r/68296/diff/5-6/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68296: Added 'handler' field to batched requests.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68296/
-----------------------------------------------------------
(Updated Aug. 14, 2018, 2:20 p.m.)
Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
Changes
-------
Moved some changes into separate reviews.
Summary (updated)
-----------------
Added 'handler' field to batched requests.
Repository: mesos
Description (updated)
-------
This commit adds a handler field to be able to batch
requests other than the `/state` request.
Diffs (updated)
-----
src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
Diff: https://reviews.apache.org/r/68296/diff/3/
Changes: https://reviews.apache.org/r/68296/diff/2-3/
Testing
-------
Thanks,
Benno Evers