[jira] [Commented] (PROTON-1093) [proton-c++] pragma to hide a warning in GCC introduces a warning in Windows

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086283#comment-15086283 ] 

ASF subversion and git services commented on PROTON-1093:
---------------------------------------------------------

Commit 89440b62dc44303a2ac16f51190dbf36195a0dcf in qpid-proton's branch refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=89440b6 ]

PROTON-1093 [proton-c++] pragma to hide a warning in GCC introduces a warning in Windows

Removed the GCC pragma (actually added for clang)
Added -Wno-old-style-cast to the list of acceptable warnings for clang.
Fixed clang warning in C code (tolower macro multiple eval of arg with side effects.)
Fixed ctor warning on windows in container.cpp


> [proton-c++] pragma to hide a warning in GCC introduces a warning in Windows
> ----------------------------------------------------------------------------
>
>                 Key: PROTON-1093
>                 URL: https://issues.apache.org/jira/browse/PROTON-1093
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: 0.12.0
>         Environment: Visual Studio 20xx
>            Reporter: Chuck Rolke
>            Assignee: Chuck Rolke
>
> proton-c\bindings\cpp\src\contexts.cpp(48) : warning C4068: unknown pragma
> #pragma GCC diagnostic ignored "-Wold-style-cast"
> commit fd52a33
> I propose fixing this by moving the pragma into cmake to leave the source with no #pragma and with no conditional to hide the pragma.
> Windows has plenty of other warnings if we're serious about squelching them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)