[GitHub] [maven-resolver] michael-o commented on a diff in pull request #178: [MRESOLVER-7] download poms in parallel

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #178:
URL: https://github.com/apache/maven-resolver/pull/178#discussion_r928152490


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java:
##########
@@ -334,6 +370,82 @@ private void doRecurse( Args args, DependencyProcessingContext parentContext,
         }
     }
 
+    private boolean filter( DependencyProcessingContext context )
+    {
+        if ( context.depSelector != null && !context.depSelector.selectDependency( context.dependency ) )

Review Comment:
   Why not compact to `return ( context.dep...)`?



##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/bf/BfDependencyCollector.java:
##########
@@ -365,6 +477,64 @@ else if ( descriptorResult == DataPool.NO_DESCRIPTOR )
         return descriptorResult;
     }
 
+    static class ParallelDescriptorResolver
+    {
+        final ExecutorService executorService;

Review Comment:
   Can this resolver leverage the same executor service as for artifacts with `aether.connector.basic.threads`? At the end it does not matter what the connector transports, no?
   
   See: org.eclipse.aether.connector.basic.BasicRepositoryConnector



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org