You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2018/05/01 15:18:40 UTC

[Impala-ASF-CR] IMPALA-5969: [DOCS] Adds --auth creds ok in clear to shell options

shashanknaikdev@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/10236 )

Change subject: IMPALA-5969: [DOCS] Adds --auth_creds_ok_in_clear to shell options
......................................................................


Patch Set 1:

> (2 comments)
 > 
 > Thank you for contributing! Some review comments are below:

Hi Jim,
Thank you for your comments.

For Line 560: I reached out to Alex for this. My understanding was that this revision number is for the version in which the documentation included this shell option in its xml. Since the feature is tagged with the revision it was included in. I was wrong, I'll revise it.

For Line 562: I tested this within my bootstrapped development environment, after building using buildall.sh and then executing start-impala-cluster.py. I checked by passing the option as an argument to the impala-shell and it was accepted. When I inserted it into the ~/.impalarc file as a key-value pair: auth_creds_ok_in_clear=true or even creds_ok_in_clear=true it displayed – “WARNING: Unable to read configuration file correctly. Ignoring unrecognized config option: 'auth_creds_ok_in_clear'.”
I also tested this on another test cluster I had access to with the same result.

Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/10236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19450ebd839b84a85598d283c04a77662fa5e44e
Gerrit-Change-Number: 10236
Gerrit-PatchSet: 1
Gerrit-Owner: shashanknaikdev@gmail.com
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: shashanknaikdev@gmail.com
Gerrit-Comment-Date: Tue, 01 May 2018 15:18:40 +0000
Gerrit-HasComments: No