You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/15 11:57:11 UTC
[GitHub] flink pull request #3907: [FLINK-6586] InputGateMetrics return 0 as minimum ...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3907
[FLINK-6586] InputGateMetrics return 0 as minimum for local channels
Should be merged for 1.3 and 1.4.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6586_network_min
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3907.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3907
----
commit c74701c17718e1260b5d2b3e96ab09c01f9d3000
Author: zentol <ch...@apache.org>
Date: 2017-05-15T11:56:06Z
[FLINK-6586] InputGateMetrics return 0 as min for local channels
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3907
Does an `InputGate` contain both local and remote `InputChannel` such that the minimum positive value might be more desirable in that case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3907: [FLINK-6586] InputGateMetrics return 0 as minimum ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3907
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3907: [FLINK-6586] InputGateMetrics return 0 as minimum ...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3907#discussion_r117479119
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java ---
@@ -86,6 +86,9 @@ int refreshAndGetMin() {
}
}
+ if (min == Integer.MAX_VALUE) { // in case all channels are local
--- End diff --
Is it worth removing the earlier check for `channels.isEmpty()` and merging the comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3907
That's a great point, haven't considered that. It may be easier to just compare the final result with `Integer.MAX_VALUE` and return `0` if the match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3907
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3907
updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3907: [FLINK-6586] InputGateMetrics return 0 as minimum ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3907#discussion_r117481827
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGateMetrics.java ---
@@ -86,6 +86,9 @@ int refreshAndGetMin() {
}
}
+ if (min == Integer.MAX_VALUE) { // in case all channels are local
--- End diff --
yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3907
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3907: [FLINK-6586] InputGateMetrics return 0 as minimum for loc...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3907
Updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---