You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/10/23 18:38:19 UTC
Re: Review Request 39400: Quota: Implemented quota API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 4:38 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
Diff: https://reviews.apache.org/r/39400/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Oct. 28, 2015, 8:54 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > <https://reviews.apache.org/r/39400/diff/5/?file=1109630#file1109630line903>
> >
> > Alex, just want to get more for why do we need to add '' for role? I know that role is user supplied, but does role will contain whitespace? If not, I think that there is no need to add '' for role output, comments? Thanks!
If I read [this](https://github.com/apache/mesos/blob/master/src/master/master.cpp#L561) correctly, nothing prevents a role from having spaces in its name.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review104265
-----------------------------------------------------------
On Oct. 27, 2015, 7:17 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 7:17 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Guangya Liu <gy...@gmail.com>.
> On Oct. 28, 2015, 8:54 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > <https://reviews.apache.org/r/39400/diff/5/?file=1109630#file1109630line903>
> >
> > Alex, just want to get more for why do we need to add '' for role? I know that role is user supplied, but does role will contain whitespace? If not, I think that there is no need to add '' for role output, comments? Thanks!
>
> Alexander Rukletsov wrote:
> If I read [this](https://github.com/apache/mesos/blob/master/src/master/master.cpp#L561) correctly, nothing prevents a role from having spaces in its name.
Thanks Alex, yes, the role can include whitespace.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review104265
-----------------------------------------------------------
On Oct. 27, 2015, 7:17 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 7:17 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review104265
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 902)
<https://reviews.apache.org/r/39400/#comment162534>
Alex, just want to get more for why do we need to add '' for role? I know that role is user supplied, but does role will contain whitespace? If not, I think that there is no need to add '' for role output, comments? Thanks!
- Guangya Liu
On 十月 27, 2015, 7:17 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated 十月 27, 2015, 7:17 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review104515
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On Oct. 27, 2015, 7:17 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 7:17 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review104255
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Oct. 28, 2015, 3:17 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 3:17 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/
-----------------------------------------------------------
(Updated Oct. 27, 2015, 7:17 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Changes
-------
Addressed comments.
Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
Diff: https://reviews.apache.org/r/39400/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line903>
> >
> > I see that in the code, some are using
> >
> > '" << xxx << "'";
> >
> > while some others are using
> >
> > \"" << xxx << "\"";
> >
> > What is the standard for different style?
> >
> > Also when shall we need to add "" for one parameter in log message?
I think we are inconsistent. AFAIK, @neilc is doing some cleanup around.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103946
-----------------------------------------------------------
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Guangya Liu <gy...@gmail.com>.
> On 十月 25, 2015, 9:06 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line903>
> >
> > I see that in the code, some are using
> >
> > '" << xxx << "'";
> >
> > while some others are using
> >
> > \"" << xxx << "\"";
> >
> > What is the standard for different style?
> >
> > Also when shall we need to add "" for one parameter in log message?
>
> Alexander Rukletsov wrote:
> I think we are inconsistent. AFAIK, @neilc is doing some cleanup around.
https://reviews.apache.org/r/39497 has been merged, it is using {{'" << xxx << "'";}}, do we need to update this patch accordingly?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103946
-----------------------------------------------------------
On 十月 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated 十月 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 903
> > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line903>
> >
> > I see that in the code, some are using
> >
> > '" << xxx << "'";
> >
> > while some others are using
> >
> > \"" << xxx << "\"";
> >
> > What is the standard for different style?
> >
> > Also when shall we need to add "" for one parameter in log message?
>
> Alexander Rukletsov wrote:
> I think we are inconsistent. AFAIK, @neilc is doing some cleanup around.
>
> Guangya Liu wrote:
> https://reviews.apache.org/r/39497 has been merged, it is using {{'" << xxx << "'";}}, do we need to update this patch accordingly?
That review only sets the precedent for executor ids, which now have a streaming operator to take care of the formatting.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103946
-----------------------------------------------------------
On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 6:25 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103946
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 902)
<https://reviews.apache.org/r/39400/#comment162053>
I see that in the code, some are using
'" << xxx << "'";
while some others are using
\"" << xxx << "\"";
What is the standard for different style?
Also when shall we need to add "" for one parameter in log message?
- Guangya Liu
On 十月 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated 十月 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Oct. 26, 2015, 6:52 a.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 897
> > <https://reviews.apache.org/r/39400/diff/4/?file=1105059#file1105059line897>
> >
> > I think we are not *moving" the role into the quota'ed role sorter, instead, we are adding it into the quota'ed role sorter, i.e., quota'ed role will be placed in both quota'd role sorter and the non-quota'ed role sorter.
My thinking was to stress that by doing that a different allocation algorithm applies. But you're right, it's misleading.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103984
-----------------------------------------------------------
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 39400: Quota: Implemented quota API.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review103984
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 896)
<https://reviews.apache.org/r/39400/#comment162126>
I think we are not *moving" the role into the quota'ed role sorter, instead, we are adding it into the quota'ed role sorter, i.e., quota'ed role will be placed in both quota'd role sorter and the non-quota'ed role sorter.
- Qian Zhang
On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2015, 12:38 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
>
> Diff: https://reviews.apache.org/r/39400/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>