[GitHub] [pulsar] eolivelli commented on a change in pull request #12692: Issue 12668: Protocol Handlers and Proxy Extensions: ability to use a dedicated EventLoopGroup for IO

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #12692:
URL: https://github.com/apache/pulsar/pull/12692#discussion_r747414719



##########
File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
##########
@@ -581,6 +581,12 @@
     )
     private Set<String> proxyExtensions = new TreeSet<>();
 
+    @FieldContext(
+            category = CATEGORY_PLUGIN,
+            doc = "Use a separate ThreadPool for each Proxy Extension"
+    )
+    private boolean useSeparateThreadPoolForProxyExtensions = true;

Review comment:
       I want to set it to true by default because it is safer for the users.
   
   if you are sharing the thread pool then you can reach to a situation in which the Broker is stuck and you do not notice it.
   
   I could add a test case,
   btw I think that no one will ever set this back to false, initially I thought to not add a configuration flag at all 
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org