You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/06 12:38:57 UTC

[GitHub] [pulsar-client-go] zymap commented on a change in pull request #502: Support listener name for go client

zymap commented on a change in pull request #502:
URL: https://github.com/apache/pulsar-client-go/pull/502#discussion_r607810772



##########
File path: pulsar/internal/lookup_service.go
##########
@@ -46,21 +46,25 @@ type LookupService interface {
 
 type lookupService struct {
 	rpcClient           RPCClient
-	serviceNameResolver ServiceNameResolver
+	serviceURL          *url.URL

Review comment:
       Why you change this? Look like we need the `ServiceNameResolver` to resolve the multiple service address.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org