[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1078: HDDS-3794. Topology Aware read does not work correctly in XceiverClientGrpc

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #1078:
URL: https://github.com/apache/hadoop-ozone/pull/1078#discussion_r441154513



##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -314,15 +314,17 @@ private XceiverClientReply sendCommandWithRetry(
           // Pull the Cached DN to the top of the DN list
           Collections.swap(datanodeList, 0, getBlockDNCacheIndex);
         }
-      } else if (topologyAwareRead) {

Review comment:
       Good catch @sodonnel . The fix LGTM overall. I just have one question:
   
   Have you consider populating blockID properly for the first getBlock() call with additional else if on the top?
   
   else if (request.getCmdType() == ContainerProtos.Type.GetBlock) {
         blockID = request.getGetBlock().getBlockID();
       }




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org