You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/26 06:52:10 UTC

[GitHub] [pulsar] yjshen opened a new pull request #6613: [cleanup] Optional usage

yjshen opened a new pull request #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613
 
 
   This PR aims to fix or simplify `Optional` type usage logic:
   - Null value used for optional type.
   - Optional.isPresent() can be replaced with functional style expression
   - Optional call chain that can be simplified.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604953121
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604294181
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604358290
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604417999
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604296055
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604943497
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604275936
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604969408
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604275936
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604296055
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604437451
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604336691
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604358290
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604919753
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604336691
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604417999
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613#issuecomment-604294181
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #6613: [cleanup] Optional usage

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6613: [cleanup] Optional usage
URL: https://github.com/apache/pulsar/pull/6613
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services