You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/17 17:31:16 UTC
[GitHub] [pulsar] HQebupt opened a new pull request, #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
HQebupt opened a new pull request, #17149:
URL: https://github.com/apache/pulsar/pull/17149
### Motivation
For a candidate broker, the addition expression maybe results in out of bounds and causes unexpected result when executing the following code.
```
Double avgResUsage = brokerAvgResourceUsageWithWeight.getOrDefault(broker, Double.MAX_VALUE);
if ((avgResUsage + diffThreshold <= avgUsage)) {
bestBrokers.add(broker);
}
```
### Modifications
Make the max resource usage as 100% instead the max double value
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
If `yes` was chosen, please highlight the changes
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17149:
URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1220283051
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17149:
URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1220217028
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17149:
URL: https://github.com/apache/pulsar/pull/17149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17149:
URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1224050497
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17149:
URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1236339172
LeastResourceUsageWithWeight is introduced in 2.11, so it's better remove the old release labels.
@mattisonchao FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17149:
URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1225018230
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #17149: [fix][broker]fix arithmetic exception for LeastResourceUsageWithWeight strategy
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17149:
URL: https://github.com/apache/pulsar/pull/17149#issuecomment-1227053014
HI @HQebupt
Would you like to cherry-pick this PR for branch 2.9 to fix this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org