You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/25 18:01:30 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #12713: Revert FilterableOptimizerContext and TranslatorOptimizerContext to OriginalOptimizerContext and CustomizedOptimizerContext

codecov-commenter commented on pull request #12713:
URL: https://github.com/apache/shardingsphere/pull/12713#issuecomment-927160102


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12713?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#12713](https://codecov.io/gh/apache/shardingsphere/pull/12713?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (42104fe) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6492547f3caa2da618c418644b3dbd3f5e98cc03?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6492547) will **decrease** coverage by `0.05%`.
   > The diff coverage is `6.25%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/12713/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/12713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #12713      +/-   ##
   ============================================
   - Coverage     63.34%   63.28%   -0.06%     
   + Complexity     1348     1346       -2     
   ============================================
     Files          2464     2464              
     Lines         37320    37329       +9     
     Branches       6432     6433       +1     
   ============================================
   - Hits          23639    23625      -14     
   - Misses        11766    11789      +23     
     Partials       1915     1915              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ecutor/sql/federate/FederationExecutorFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9GZWRlcmF0aW9uRXhlY3V0b3JGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...omized/CustomizedFilterableExecuteDataContext.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9jdXN0b21pemVkL0N1c3RvbWl6ZWRGaWx0ZXJhYmxlRXhlY3V0ZURhdGFDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...erate/customized/CustomizedFilterableExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9jdXN0b21pemVkL0N1c3RvbWl6ZWRGaWx0ZXJhYmxlRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ecutor/sql/federate/original/FilterableSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9vcmlnaW5hbC9GaWx0ZXJhYmxlU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../federate/original/OriginalFilterableExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9vcmlnaW5hbC9PcmlnaW5hbEZpbHRlcmFibGVFeGVjdXRvci5qYXZh) | `0.00% <ø> (ø)` | |
   | [...federate/original/row/FilterableRowEnumerator.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9vcmlnaW5hbC9yb3cvRmlsdGVyYWJsZVJvd0VudW1lcmF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...ginal/sql/FilterableExecutionContextGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9vcmlnaW5hbC9zcWwvRmlsdGVyYWJsZUV4ZWN1dGlvbkNvbnRleHRHZW5lcmF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../federate/original/sql/FilterableSQLGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9vcmlnaW5hbC9zcWwvRmlsdGVyYWJsZVNRTEdlbmVyYXRvci5qYXZh) | `0.00% <ø> (ø)` | |
   | [.../sql/federate/original/sql/RouteContextFilter.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9vcmlnaW5hbC9zcWwvUm91dGVDb250ZXh0RmlsdGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...r/sql/federate/original/table/FilterableTable.java](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9mZWRlcmF0ZS9vcmlnaW5hbC90YWJsZS9GaWx0ZXJhYmxlVGFibGUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/shardingsphere/pull/12713/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12713?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12713?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1ddc1ad...42104fe](https://codecov.io/gh/apache/shardingsphere/pull/12713?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org