[jira] [Commented] (YARN-422) Add AM-NM client library

["Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639639#comment-13639639 ] 

Vinod Kumar Vavilapalli commented on YARN-422:
----------------------------------------------

Comments on your proposal
 - AMNMClient is good.
 - We should have only one instance per AM which talks to *all* NMs. Just like ContainerLauncherImpl in MR App. Clearly, the interface you proposed is already accommodating for that.
 - All the APIs will be blocking? It isn't clear. Today's MR App's ContainerLauncher is non-blocking and it has call-backs/signals as to what happened with a container launch/stop - succeeded/failed. I like making it non-blocking as AMs more commonly should want to kick off the launch and go away. A blocking API could be implemented on top of the non-blocking API if need be.
 - I think we should change AMLauncher also to use this, but we can scope it into a separate ticket depending on this patch's size

What do others think?
                
> Add AM-NM client library
> ------------------------
>
>                 Key: YARN-422
>                 URL: https://issues.apache.org/jira/browse/YARN-422
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Zhijie Shen
>         Attachments: proposal_v1.pdf
>
>
> Create a simple wrapper over the AM-NM container protocol to provide hide the details of the protocol implementation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira