[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #7315: GEODE-9991: Configure SSLParameters directly.

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #7315:
URL: https://github.com/apache/geode/pull/7315#discussion_r793661535



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##########
@@ -362,38 +362,36 @@ public SSLEngine createSSLEngine(String hostName, int port, boolean clientSocket
   }
 
   @VisibleForTesting
-  void configureSSLEngine(SSLEngine engine, String hostName, int port, boolean clientSocket) {
-    SSLParameters parameters = engine.getSSLParameters();
-    boolean updateEngineWithParameters = false;
+  void configureSSLEngine(final SSLEngine engine, final String hostName, final int port,
+      final boolean clientSocket) {
+    engine.setUseClientMode(clientSocket);
+    final SSLParameters parameters = engine.getSSLParameters();
+    configureSSLParameters(parameters, hostName, port, clientSocket);
+    engine.setSSLParameters(parameters);

Review comment:
       I couldn't find any good reason. I think It was an attempt to avoid the issues reported in [GEODE-8419](https://issues.apache.org/jira/browse/GEODE-8419). But looking at the sources setting all these parameters via the `SSLParameters` is the safest approach. Alternatively we could get and set the SSLParameters around each parameter.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org