[GitHub] [mynewt-core] ccollins476ad commented on issue #1770: sys/console: start pkt should set g_is_output_nlip

[GitBox <gi...@apache.org>]

ccollins476ad commented on issue #1770: sys/console: start pkt should set g_is_output_nlip
URL: https://github.com/apache/mynewt-core/pull/1770#issuecomment-483937098
 
 
   I only see it being used in `console_write()`, so I think it can be made into a normal local variable (non static).
   
   One other minor thing - I would really prefer to see a brief comment above the
   ```
       if (cnt >= 3 && str[1] == CONSOLE_NLIP_PKT_START1 &&
   ```
   line.  It seems weird that we check the first two bytes for "DATA" packets, but check bytes 2 and 3 for "START" packets (I know why this is the case, but I doubt anyone else does!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services