You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/27 21:19:44 UTC
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5456: Single Quote String Literal for function invoker results
fx19880617 opened a new pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456
This fix the issue that of function invoker string output breaks query syntax.
E.g.
query: `SELECT toDateTime(now(), 'yyyy-MM-dd z') FROM mytable` becomes:
`SELECT 2020-05-27 UTC FROM mytable`. And not recognized in Transformation function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #5456: Single Quote String Literal for function invoker results
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635099149
I think the real issue is BrokerRequest is incapable of storing expressions correctly, it converts them to String. This seems like a temp workaround (approving it on that pretext).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg merged pull request #5456: Single Quote String Literal for function invoker results
Posted by GitBox <gi...@apache.org>.
kishoreg merged pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on pull request #5456: Single Quote String Literal for function invoker results
Posted by GitBox <gi...@apache.org>.
kishoreg commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-634948647
looks like this fix is a workaround to hide the actual problem in transform function?
What would be the exception/error in transformfunction without this fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on pull request #5456: Single Quote String Literal for function invoker results
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-634954131
> looks like this fix is a workaround to hide the actual problem in transform function?
>
> What would be the exception/error in transformfunction without this fix
There is no error, in brokerRequest, it's converted to a string. E.g. if the literal is `2020-05-27`, without single quote, transform function will parse it to `2020` only.
See here :
TransformExpressionTree.compileToExpressionTree("2020-05-27 UTC") = '2020'
TransformExpressionTree.compileToExpressionTree("'2020-05-27 UTC'") = '2020-05-27 UTC'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on pull request #5456: Single Quote String Literal for function invoker results
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635100955
> I think the real issue is BrokerRequest is incapable of storing expressions correctly, it converts them to String. This seems like a temp workaround (approving it on that pretext). The ideal fix is to move to PinotQuery.
Correct, this is also mention by @kishoreg , I will soon started move query processing from brokerRequest to PinotQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 edited a comment on pull request #5456: Single Quote String Literal for function invoker results
Posted by GitBox <gi...@apache.org>.
fx19880617 edited a comment on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635100955
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv edited a comment on pull request #5456: Single Quote String Literal for function invoker results
Posted by GitBox <gi...@apache.org>.
mayankshriv edited a comment on pull request #5456:
URL: https://github.com/apache/incubator-pinot/pull/5456#issuecomment-635099149
I think the real issue is BrokerRequest is incapable of storing expressions correctly, it converts them to String. This seems like a temp workaround (approving it on that pretext). The ideal fix is to move to PinotQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org