You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/23 12:03:37 UTC

[GitHub] [pulsar-client-go] mmahadikar-ns opened a new pull request #549: [Issue 515][pulsar-producer]Fix for Producer Send and SendAsyn is blocked forever when pulsar is down.

mmahadikar-ns opened a new pull request #549:
URL: https://github.com/apache/pulsar-client-go/pull/549


    Issue link - https://github.com/apache/pulsar-client-go/issues/515
   
   Signed-off-by: Megaraj Mahadikar <me...@gmail.com>
   
   <--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #515
   
   ### Motivation
   Producer `Send` and `SendAsyn` is blocked forever when pulsar is down if the MaxReconnectToBroker is set to unlimited retry. In case of pulsar down scenarios, within runEventsLoop in producer_partition.go, the call enters reconnectToBroker and remains in a forever loop until the pulsar broker connection is established. Due to this, no more events are consumed from eventsChan channel causing both `Send` and `SendAsyn` to be blocked. Due to this, the SendTimeout would also be not honoured.
   
   ### Modifications
   
   In runEventsLoop, have a separate go-routine working on connectClosedCh channel. This way eventsChan is never blocked.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] megarajtm commented on pull request #549: [Issue 515][pulsar-producer]Fix for Producer Send and SendAsyn is blocked forever when pulsar is down.

Posted by GitBox <gi...@apache.org>.
megarajtm commented on pull request #549:
URL: https://github.com/apache/pulsar-client-go/pull/549#issuecomment-866809257


   Closing this PR. Will create a new PR for these changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] megarajtm removed a comment on pull request #549: [Issue 515][pulsar-producer]Fix for Producer Send and SendAsyn is blocked forever when pulsar is down.

Posted by GitBox <gi...@apache.org>.
megarajtm removed a comment on pull request #549:
URL: https://github.com/apache/pulsar-client-go/pull/549#issuecomment-866809257


   Closing this PR. Will create a new PR for these changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] mmahadikar-ns closed pull request #549: [Issue 515][pulsar-producer]Fix for Producer Send and SendAsyn is blocked forever when pulsar is down.

Posted by GitBox <gi...@apache.org>.
mmahadikar-ns closed pull request #549:
URL: https://github.com/apache/pulsar-client-go/pull/549


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org