You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/02 20:34:32 UTC
[GitHub] [tvm] jwfromm opened a new pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
jwfromm opened a new pull request #7394:
URL: https://github.com/apache/tvm/pull/7394
The current implementation of `Where` in our importer uses static shape analysis to do broadcasting. Unfortunately, this can break when inputs have dynamic shapes. This PR refactors the analysis to instead support dynamism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7394:
URL: https://github.com/apache/tvm/pull/7394#issuecomment-772099321
My goto has been do throw in a `shape_of` op and do some computations on it to get dynamic inputs, even if it's just `op(x) -> op(reshape(x, shape_of(x))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #7394:
URL: https://github.com/apache/tvm/pull/7394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7394:
URL: https://github.com/apache/tvm/pull/7394#issuecomment-772099321
My goto has been do throw in a `shape_of` op and do some computations on it to get dynamic inputs, even if it's just `op(x) -> op(reshape(x, shape_of(x))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7394:
URL: https://github.com/apache/tvm/pull/7394#issuecomment-774117590
Thanks @jwfromm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7394:
URL: https://github.com/apache/tvm/pull/7394#issuecomment-771963702
@soiferj can you take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7394:
URL: https://github.com/apache/tvm/pull/7394#issuecomment-771963702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7394: [Relay][Frontend][Onnx] Refactor where importer to support dynamic shapes.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7394:
URL: https://github.com/apache/tvm/pull/7394#issuecomment-772084289
I would definitely like to but wasn't sure what the right way to force dynamic shapes in a model is. I think we would need to compose a composite graph of some dynamic op followed by where, which might be a very ugly test. Do you know a better way to do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org