You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2018/04/23 09:13:05 UTC
[GitHub] flink pull request #5897: [FLINK-9234] [table] Fix missing dependencies for ...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5897
[FLINK-9234] [table] Fix missing dependencies for external catalogs
## What is the purpose of the change
This PR adds the required dependencies `commons-logging` (via `slf4j`) and `commons-collections` to `flink-table`. They are required for the deprecated external catalog discovery.
## Brief change log
Modified `pom.xml`.
## Verifying this change
Manually verified.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-9234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5897.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5897
----
commit 1c4a6695496f021a6be7bc58090bdc64a97aa87e
Author: Timo Walther <tw...@...>
Date: 2018-04-23T09:04:51Z
[FLINK-9234] [table] Fix missing dependencies for external catalogs
----
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
Forwarding some comment from @fhueske from JIRA:
> I tried to reproduce this issue for 1.5 but it seems to work.
>
> Flink 1.5 should be out soon (release candidate 2 was published two days ago). We can merge a fix for 1.4, but would need to wait for 1.4.3 to be released before it is publicly available (unless you build from the latest 1.4 branch).
>
> `commons-configuration` is used for the external catalog support that was recently reworked for the unified table source generation. The code that needs the dependency was deprecated. I think we can drop the code and dependency for the 1.6 release.
That means we should merge this into `release-1.4` and `release-1.5`. In `master`, we could merge this, but should probably simply drop the pre-unified-source code.
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
Agreed, let's add it to master as well...
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by nezhazheng <gi...@git.apache.org>.
Github user nezhazheng commented on the issue:
https://github.com/apache/flink/pull/5897
encountered same issue.
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/5897
any progress on this?
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5897
The Flink code doesn't need the `jcl` dependency but if `commons` libraries want to log something we should make this possible, right? Good point @zentol. I will verify the logs again.
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
Can we actually get rid of `commons-configuration` in the table API?
All the commons packages with their weird long tail of not properly declared dependencies have become a bit of an anti-pattern to me over time...
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by tragicjun <gi...@git.apache.org>.
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/5897
encountered the same issue, any progress on this?
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5897
From my side, +1 to merge this to `release-1.4` and `release-1.5`.
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5897
@zentol @EronWright would be great if you could verify my changes
---
[GitHub] flink pull request #5897: [FLINK-9234] [table] Fix missing dependencies for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5897
---
[GitHub] flink issue #5897: [FLINK-9234] [table] Fix missing dependencies for externa...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5897
Thanks, @StephanEwen.
I will later merge this for `release-1.4` and `release-1.5`. Should we merge it for `master` as well and create a JIRA to drop the deprecated code? That would ensure we have the fix in 1.6 as well in case we don't drop the code for whatever reason.
---