You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/08/20 08:27:17 UTC
[Apache Bloodhound] #162: Convert version control user interface to
Bootstrap
#162: Convert version control user interface to Bootstrap
--------------------------------+-----------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Release 3
Component: ui design | Version:
Keywords: versioncontrol vcs |
--------------------------------+-----------------------
All views related to the repository (e.g. browser, changesets, log ... )
have not been still have legacy styles . They should be converted to
bootstrap.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by olemis):
I have refreshed the patch for repository browser to incorporate CSS
styles for directory listings
[[Image(bh_theme_x_83_dir_list.png, width=600)]]
... and repository index
[[Image(bh_theme_x_84_repos_index.png, width=600)]]
Feedback is welcome .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: closed
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: fixed | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Changes (by rjollos):
* status: review => closed
* resolution: => fixed
Comment:
Thanks to this nice work by Olemis, the repository browsers and revision
log seem to be in pretty good shape. I don't see any major issues at the
moment, and refinements can be discussed for the next release. We still
need a Bootstrap template for the `changeset` view. I don't foresee having
time do that before Release 5, so I'm closing this for now.
----
(In [1453194])
Refs #162: Updated release notes.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:18>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by olemis):
I refreshed all previous patches mainly in spite of aligning changeset
rows in revision log next to the corresponding indicator in revision graph
. Patch order listed below
{{{
#!sh
$ hg qapplied
t162/t162_r1398842_bootstrap_revlog.diff
t162/t162_r1398842_bootstrap_browser.diff
t162/t162_r1398842_bootstrap_revgraph.diff
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by olemis):
@rjollos : now I don't recall whether I implemented blame support into
these templates . Could you please check ?
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner:
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Changes (by jdreimann):
* owner: jdreimann =>
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by rjollos):
(In [1453168])
Refs #162: Applied patch `t162_r1433074_bootstrap_browser.diff` from
Olemis, with modifications to keep elements contained within the
`#content` `div`.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:16>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: gjm
Type: enhancement | Status: review
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Changes (by olemis):
* status: accepted => review
* owner: olemis => gjm
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Description changed by olemis:
Old description:
> All views related to the repository (e.g. browser, changesets, log ... )
> have not been still have legacy styles . They should be converted to
> bootstrap.
New description:
All views related to the repository (e.g. browser, changesets, log ... )
still have legacy styles . They have to be converted to bootstrap.
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by rjollos):
(In [1453170])
Refs #162: Applied patch `t162_r1433074_bootstrap_revgraph.diff` from
Olemis.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:17>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Changes (by rjollos):
* owner: gjm => rjollos
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:12>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: gjm
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by olemis):
I have refreshed patches for this ticket
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user interface
to Bootstrap
Posted by Olemis Lang <ol...@gmail.com>.
On 10/7/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #162: Convert version control user interface to Bootstrap
>
[...]
>
> Attached patch implements a proposal to convert revision log web UI to
> ''Bootstrap'' styling .
It illustrates the kind of work needed to get this done . I'm hoping
it will be considered as a reference to convert remaining VCS Genshi
templates .
What do you think ?
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner:
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by olemis):
Attached patch implements a proposal to convert revision log web UI to
''Bootstrap'' styling . After applying it against theme plugin @ r1394017
it will look like this
[[Image(bh_theme_x_73_revlog.png, width=600)]]
It's very similar to ''Trac'' 's . Notice that
1. File path moved to breadcrumbs nav area
1. Size of long paths is controlled by including some paths items in a
drop down menu . This is necessary because repository depth may be
arbitrary but there's limited space in the UI .
1. It's not possible to copy full path . I've read this is a requirement
considered by ''Trac'' . I was thinking of including a tiny control in
breadcrumbs for this purpose .
Feedback appreciated .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by olemis):
Today I started conversion to Bootstrap of repository browser file preview
. Proposed interface looks like shown below
[[Image(bh_theme_x_78_file_preview.png, 600)]]
The lines in file contents area have been introduced as a side effect of
work previously committed for #88 . They should be removed by applying the
following tiny update
{{{
#!diff
$ hg diff
diff -r cc1f958d80ae bhtheme/theme.py
--- a/bhtheme/theme.py Wed Oct 17 01:17:09 2012 -0500
+++ b/bhtheme/theme.py Wed Oct 17 01:37:12 2012 -0500
@@ -122,6 +122,8 @@
"""Insert default Bootstrap CSS classes if rendering
legacy templates (i.e. determined by template name prefix).
"""
+ if filename.startswith('bh_'):
+ return stream;
tx = Transformer('body')
def add_classes(classes):
}}}
Isn't it about time to commit this modification ?
Any other comments | suggestions are welcome .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by rjollos):
Sure, I will check. I've started work on this ticket today.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user interface
to Bootstrap
Posted by Gary Martin <ga...@wandisco.com>.
I could try to set up something so that Joe can see enough to inspire
him. That might save any potential wasted effort.
Cheers,
Gary
On 04/09/12 00:30, Olemis Lang wrote:
> ok . I'll suggest something and later you'll be able to improve on
> what we'll have .
> Is it ok ?
>
> On 9/3/12, Joachim Dreimann <jo...@wandisco.com> wrote:
>> After some further investigation, I'll pass on this for now. I found it
>> difficult to get familiar enough with the system over the last week to make
>> any useful recommendations. Once #156 has been implemented I'll make
>> individual suggestions as I notice things.
>>
>> - Joe
>>
>>
>> On 29 Aug 2012, at 04:49, Olemis Lang <ol...@gmail.com> wrote:
>>
>>> awesome !
>>> :)
>>>
>>> PS: there are some «not obvious» features that should be mention e.g.
>>> highlighting of source rows while browsing file contents , popovers in
>>> blame view ... indeed this is a tough task as there are many concerns
>>> involved .
>>>
>>>
>>> On 8/28/12, Apache Bloodhound <bl...@incubator.apache.org>
>>> wrote:
>>>> #162: Convert version control user interface to Bootstrap
>>>> --------------------------+--------------------------------
>>>> Reporter: olemis | Owner: jdreimann
>>>> Type: enhancement | Status: assigned
>>>> Priority: major | Milestone: Release 3
>>>> Component: ui design | Version:
>>>> Resolution: | Keywords: versioncontrol vcs
>>>> --------------------------+--------------------------------
>>>> Changes (by jdreimann):
>>>>
>>>> * status: new => assigned
>>>> * owner: nobody => jdreimann
>>>>
>>>>
>>>> Comment:
>>>>
>>>> I'll have a look into this to come up with suggestions as to what they
>>>> may
>>>> look like.
>>>>
>>>> --
>>>> Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:2>
>>>> Apache Bloodhound <https://issues.apache.org/bloodhound/>
>>>> The Apache Bloodhound (incubating) issue tracker
>>>>
>>>
>>> --
>>> Regards,
>>>
>>> Olemis.
>>>
>>> Blog ES: http://simelo-es.blogspot.com/
>>> Blog EN: http://simelo-en.blogspot.com/
>>>
>>> Featured article:
>>
>
Re: [Apache Bloodhound] #162: Convert version control user interface
to Bootstrap
Posted by Olemis Lang <ol...@gmail.com>.
ok . I'll suggest something and later you'll be able to improve on
what we'll have .
Is it ok ?
On 9/3/12, Joachim Dreimann <jo...@wandisco.com> wrote:
> After some further investigation, I'll pass on this for now. I found it
> difficult to get familiar enough with the system over the last week to make
> any useful recommendations. Once #156 has been implemented I'll make
> individual suggestions as I notice things.
>
> - Joe
>
>
> On 29 Aug 2012, at 04:49, Olemis Lang <ol...@gmail.com> wrote:
>
>> awesome !
>> :)
>>
>> PS: there are some «not obvious» features that should be mention e.g.
>> highlighting of source rows while browsing file contents , popovers in
>> blame view ... indeed this is a tough task as there are many concerns
>> involved .
>>
>>
>> On 8/28/12, Apache Bloodhound <bl...@incubator.apache.org>
>> wrote:
>>> #162: Convert version control user interface to Bootstrap
>>> --------------------------+--------------------------------
>>> Reporter: olemis | Owner: jdreimann
>>> Type: enhancement | Status: assigned
>>> Priority: major | Milestone: Release 3
>>> Component: ui design | Version:
>>> Resolution: | Keywords: versioncontrol vcs
>>> --------------------------+--------------------------------
>>> Changes (by jdreimann):
>>>
>>> * status: new => assigned
>>> * owner: nobody => jdreimann
>>>
>>>
>>> Comment:
>>>
>>> I'll have a look into this to come up with suggestions as to what they
>>> may
>>> look like.
>>>
>>> --
>>> Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:2>
>>> Apache Bloodhound <https://issues.apache.org/bloodhound/>
>>> The Apache Bloodhound (incubating) issue tracker
>>>
>>
>>
>> --
>> Regards,
>>
>> Olemis.
>>
>> Blog ES: http://simelo-es.blogspot.com/
>> Blog EN: http://simelo-en.blogspot.com/
>>
>> Featured article:
>
>
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #162: Convert version control user interface to Bootstrap
Posted by Joachim Dreimann <jo...@wandisco.com>.
After some further investigation, I'll pass on this for now. I found it difficult to get familiar enough with the system over the last week to make any useful recommendations. Once #156 has been implemented I'll make individual suggestions as I notice things.
- Joe
On 29 Aug 2012, at 04:49, Olemis Lang <ol...@gmail.com> wrote:
> awesome !
> :)
>
> PS: there are some «not obvious» features that should be mention e.g.
> highlighting of source rows while browsing file contents , popovers in
> blame view ... indeed this is a tough task as there are many concerns
> involved .
>
>
> On 8/28/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
>> #162: Convert version control user interface to Bootstrap
>> --------------------------+--------------------------------
>> Reporter: olemis | Owner: jdreimann
>> Type: enhancement | Status: assigned
>> Priority: major | Milestone: Release 3
>> Component: ui design | Version:
>> Resolution: | Keywords: versioncontrol vcs
>> --------------------------+--------------------------------
>> Changes (by jdreimann):
>>
>> * status: new => assigned
>> * owner: nobody => jdreimann
>>
>>
>> Comment:
>>
>> I'll have a look into this to come up with suggestions as to what they may
>> look like.
>>
>> --
>> Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:2>
>> Apache Bloodhound <https://issues.apache.org/bloodhound/>
>> The Apache Bloodhound (incubating) issue tracker
>>
>
>
> --
> Regards,
>
> Olemis.
>
> Blog ES: http://simelo-es.blogspot.com/
> Blog EN: http://simelo-en.blogspot.com/
>
> Featured article:
Re: [Apache Bloodhound] #162: Convert version control user interface
to Bootstrap
Posted by Olemis Lang <ol...@gmail.com>.
awesome !
:)
PS: there are some «not obvious» features that should be mention e.g.
highlighting of source rows while browsing file contents , popovers in
blame view ... indeed this is a tough task as there are many concerns
involved .
On 8/28/12, Apache Bloodhound <bl...@incubator.apache.org> wrote:
> #162: Convert version control user interface to Bootstrap
> --------------------------+--------------------------------
> Reporter: olemis | Owner: jdreimann
> Type: enhancement | Status: assigned
> Priority: major | Milestone: Release 3
> Component: ui design | Version:
> Resolution: | Keywords: versioncontrol vcs
> --------------------------+--------------------------------
> Changes (by jdreimann):
>
> * status: new => assigned
> * owner: nobody => jdreimann
>
>
> Comment:
>
> I'll have a look into this to come up with suggestions as to what they may
> look like.
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:2>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound (incubating) issue tracker
>
--
Regards,
Olemis.
Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/
Featured article:
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: jdreimann
Type: enhancement | Status: assigned
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Changes (by jdreimann):
* status: new => assigned
* owner: nobody => jdreimann
Comment:
I'll have a look into this to come up with suggestions as to what they may
look like.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: olemis
Type: enhancement | Status: accepted
Priority: major | Milestone: Release 3
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Changes (by olemis):
* owner: => olemis
* status: assigned => accepted
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #162: Convert version control user
interface to Bootstrap
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#162: Convert version control user interface to Bootstrap
--------------------------+--------------------------------
Reporter: olemis | Owner: rjollos
Type: enhancement | Status: review
Priority: major | Milestone: Release 5
Component: ui design | Version:
Resolution: | Keywords: versioncontrol vcs
--------------------------+--------------------------------
Comment (by rjollos):
(In [1452706])
Refs #162: Applied ` t162_r1433074_bootstrap_revlog.diff` from Olemis.
Some additional `span12` classes were applied to align elements.
Additional patches will be applied on top of this one.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/162#comment:15>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker