You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/03/26 00:10:09 UTC
Review Request 32504: Removed MasterInfo from REGISTER and REREGISTER
scheduler calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
Diffs
-----
include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
Diff: https://reviews.apache.org/r/32504/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32504: Removed MasterInfo from REGISTER and
REREGISTER scheduler calls.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/#review78038
-----------------------------------------------------------
src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/32504/#comment126427>
I think just saying 'registered' is enough, since it is nothing else it registeres with.
src/examples/low_level_scheduler_libprocess.cpp
<https://reviews.apache.org/r/32504/#comment126428>
ditto
src/examples/low_level_scheduler_pthread.cpp
<https://reviews.apache.org/r/32504/#comment126429>
ditto.
src/examples/low_level_scheduler_pthread.cpp
<https://reviews.apache.org/r/32504/#comment126430>
ditto.
- Alexander Rojas
On March 26, 2015, 12:10 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32504/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 12:10 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
>
> Diff: https://reviews.apache.org/r/32504/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32504: Removed MasterInfo from REGISTER and
REREGISTER scheduler calls.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 8, 2015, 11:41 p.m., Isabel Jimenez wrote:
> > src/scheduler/scheduler.cpp, line 583
> > <https://reviews.apache.org/r/32504/diff/2/?file=910157#file910157line583>
> >
> > Shouldn't we apply this same reasoning in sched.cpp?
Not really. Frameworks currently depend on MasterInfo to know which master they are connected to. With the new API, they will be in explicit control of the connection, so they will know.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/#review79452
-----------------------------------------------------------
On March 31, 2015, 12:08 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32504/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 12:08 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
>
> Diff: https://reviews.apache.org/r/32504/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32504: Removed MasterInfo from REGISTER and
REREGISTER scheduler calls.
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/#review79452
-----------------------------------------------------------
src/scheduler/scheduler.cpp
<https://reviews.apache.org/r/32504/#comment128839>
Shouldn't we apply this same reasoning in sched.cpp?
- Isabel Jimenez
On March 31, 2015, 12:08 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32504/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 12:08 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
>
> Diff: https://reviews.apache.org/r/32504/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32504: Removed MasterInfo from REGISTER and
REREGISTER scheduler calls.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/#review79368
-----------------------------------------------------------
Ship it!
- Alexander Rukletsov
On March 31, 2015, 12:08 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32504/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 12:08 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
>
> Diff: https://reviews.apache.org/r/32504/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32504: Removed MasterInfo from REGISTER and
REREGISTER scheduler calls.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/
-----------------------------------------------------------
(Updated April 20, 2015, 8 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased. NNFR.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
Diff: https://reviews.apache.org/r/32504/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 32504: Removed MasterInfo from REGISTER and
REREGISTER scheduler calls.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/#review78414
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 31, 2015, 12:08 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32504/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 12:08 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1127
> https://issues.apache.org/jira/browse/MESOS-1127
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
> src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
> src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
> src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
>
> Diff: https://reviews.apache.org/r/32504/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 32504: Removed MasterInfo from REGISTER and
REREGISTER scheduler calls.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32504/
-----------------------------------------------------------
(Updated March 31, 2015, 12:08 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
alexr's comments.
Bugs: MESOS-1127
https://issues.apache.org/jira/browse/MESOS-1127
Repository: mesos
Description
-------
Removed MasterInfo from REGISTER and REREGISTER scheduler calls because they don't provide much value in a HTTP API world because the scheduler knows precisely who it is connecting to.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto 783a63ad1cc0edd86605d638046fb959cb6e97e8
src/examples/low_level_scheduler_libprocess.cpp 63d34eefb60d13fe2b82905c1cec9b762340e997
src/examples/low_level_scheduler_pthread.cpp 6d1f938660c02db75bfcbf7c8de0d941cff1920d
src/scheduler/scheduler.cpp 584b042e32865fdf875bf41ebcfb7f9c327d882a
Diff: https://reviews.apache.org/r/32504/diff/
Testing
-------
make check
Thanks,
Vinod Kone