Re: [PR] [test] Add Rust integration coverage for RecordBatchLogReader bounded reads. [fluss-rust]

["slfan1989 (via GitHub)" <gi...@apache.org>]

slfan1989 commented on code in PR #559:
URL: https://github.com/apache/fluss-rust/pull/559#discussion_r3298542451


##########
crates/fluss/tests/integration/record_batch_log_reader.rs:
##########
@@ -0,0 +1,368 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#[cfg(test)]
+mod reader_test {

Review Comment:
   Got it, that makes sense. I interpreted `past_end_of_log` as immediate completion when the requested stop offset is beyond the current log end, which would require querying/clamping latest offsets.
   
   I'll add a test for the wait-and-resume scenario instead: create a reader with a stop offset past the current end, start collecting, append more records later so the log crosses the stop offset, and verify the reader resumes and finishes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org