[jira] Commented: (JAMES-359) remote address from Received header is not handled

["Stefano Bagnara (JIRA)" <se...@james.apache.org>]

     [ http://issues.apache.org/jira/browse/JAMES-359?page=comments#action_61888 ]
     
Stefano Bagnara commented on JAMES-359:
---------------------------------------

I just downloaded the latest SVN revision from "branch_2_1_fcs" and it seems to be fixed.

> remote address from Received header is not handled
> --------------------------------------------------
>
>          Key: JAMES-359
>          URL: http://issues.apache.org/jira/browse/JAMES-359
>      Project: James
>         Type: Bug
>   Components: FetchMail
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara

>
> Look at this method code:
>     protected String computeRemoteDomain() throws MessagingException
>     {
>         StringBuffer domainBuffer = new StringBuffer();
>         String[] headers = null;
>         if (getRemoteReceivedHeaderIndex() > -1)
>               getMessageIn().getHeader(RFC2822Headers.RECEIVED);
>         if (null != headers)
>             # DO SOMETHING....
>         }
>         // Default is "localhost"
>         if (domainBuffer.length() == 0)
>             domainBuffer.append("localhost");
>         return domainBuffer.toString().trim();
>     }
>  
> You can see that there is a missing assignment to "headers = " before the "getMessageIn().getHeader()" stuff.
> Without the assignment this code will never work and the remote address recognition feature is not working ad all. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org