You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/14 18:28:07 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #12050: fix:
enable `dispatchAction` highlight downplay for treemap. fix #9816.
100pah opened a new pull request #12050: fix: enable `dispatchAction` highlight downplay for treemap. fix #9816.
URL: https://github.com/apache/incubator-echarts/pull/12050
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
fix: enable `dispatchAction` highlight downplay for treemap.
### Fixed issues
fix #9816.
## Details
### Before: What was the problem?
Can not `dispatchAction` highlight downplay for treemap.
### After: How is it fixed in this PR?
Enabled.
### Related test cases or examples to use the new APIs
`test/treemap-disk2.html`
## Others
### Remain issue
Whether highlight/downplay will effect all the subtree or only the hovered node?
There are both scenarios, depending on the styles the treemap used. For example,
a treemap uses border to distinguish the highlighted subtree, we should only
highlight the target node rather than the entire subtree. Otherwise the all of the
border inner the subtree will be highlighted unexpectedly. If a treemap uses area
color to distinguish the highlighted subtree, the entire subtree needed to be
highlighted.
But I only support "highlight single node" here. Because based on the current
mechanism, implement "highlight entire subtree" need some more code, a little
like `focusNodeAdjacency` in `graph series`, and event more complicated because
the zrender elements in treemap are nested so we need to consider a mouse over
listener should/should not listen to its descendent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #12050: fix: enable
`dispatchAction` highlight downplay for treemap. fix #9816.
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #12050: fix: enable `dispatchAction` highlight downplay for treemap. fix #9816.
URL: https://github.com/apache/incubator-echarts/pull/12050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12050:
fix: enable `dispatchAction` highlight downplay for treemap. fix #9816.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12050: fix: enable `dispatchAction` highlight downplay for treemap. fix #9816.
URL: https://github.com/apache/incubator-echarts/pull/12050#issuecomment-574309427
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12050:
fix: enable `dispatchAction` highlight downplay for treemap. fix #9816.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12050: fix: enable `dispatchAction` highlight downplay for treemap. fix #9816.
URL: https://github.com/apache/incubator-echarts/pull/12050#issuecomment-574531094
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org