You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by al...@apache.org on 2016/10/12 13:08:57 UTC
[2/5] brooklyn-server git commit: Remove duplicate thread renaming
Remove duplicate thread renaming
The code in beforeStartAtomicTask overrides the value set here. Keeping the other one as it's called for scheduled tasks as well.
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/05622be2
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/05622be2
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/05622be2
Branch: refs/heads/master
Commit: 05622be2cd4ad252d1e0be6bdc086fe81563ff9d
Parents: 5fc8344
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Authored: Sun Oct 2 12:52:13 2016 +0300
Committer: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Committed: Tue Oct 11 09:20:18 2016 +0300
----------------------------------------------------------------------
.../brooklyn/util/core/task/BasicExecutionManager.java | 9 ---------
1 file changed, 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/05622be2/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java b/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
index 8bb7705..1bf5eca 100644
--- a/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
+++ b/core/src/main/java/org/apache/brooklyn/util/core/task/BasicExecutionManager.java
@@ -516,13 +516,7 @@ public class BasicExecutionManager implements ExecutionManager {
try {
T result = null;
Throwable error = null;
- String oldThreadName = Thread.currentThread().getName();
try {
- if (RENAME_THREADS) {
- String newThreadName = oldThreadName+"-"+task.getDisplayName()+
- "["+task.getId().substring(0, 8)+"]";
- Thread.currentThread().setName(newThreadName);
- }
beforeStartAtomicTask(flags, task);
if (!task.isCancelled()) {
result = ((TaskInternal<T>)task).getJob().call();
@@ -530,9 +524,6 @@ public class BasicExecutionManager implements ExecutionManager {
} catch(Throwable e) {
error = e;
} finally {
- if (RENAME_THREADS) {
- Thread.currentThread().setName(oldThreadName);
- }
afterEndAtomicTask(flags, task);
}
if (error!=null) {