[jira] [Commented] (HDFS-4694) The SecondaryNameNode may change the inode id of root while doing checkpoint

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631470#comment-13631470 ] 

Hadoop QA commented on HDFS-4694:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12578663/HDFS-4694.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4245//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4245//console

This message is automatically generated.
                
> The SecondaryNameNode may change the inode id of root while doing checkpoint
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-4694
>                 URL: https://issues.apache.org/jira/browse/HDFS-4694
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4694.001.patch
>
>
> SNN will call FSNamesystem#clear while merging the fsimage to its local FSNamesystem, and the FSDirectory will be reset in this process. However, in FSDirectory#reset, a new inode id will be allocated and assigned to the new root.
> To fix the problem, we can either pass in an inode id in FSDirectory#createRoot, or update the root id in FSImageFormat#updateRootAttr.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira