You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/04/15 10:08:31 UTC

apre2 and httpd versions

Hi Joe,

Can I get an authoritative answer on apreq2 supporting httpd versions 
1.3.x ?

For instance configure --with-apache1-apxs
Yet, I dont' see how this could possibly work... I assume it was added
for the future when this library supports both.

The current problem is that it still tries to install
the 1.3.x version during make install and because
APACHE1_APXS doesn't exist you get errors.

I'm hoping the correct fix is to prevent make
from cd'ing into modules/apache if you don't specify
--with-apache1-apxs and only modules/apache2

Thoughts ?

P.S.
   If you like e-mail me off list and I'll send you a svn diff
of all the previous patches as one.

END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com


Re: [PATCH[ Re: apre2 and httpd versions

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Joe Schaefer wrote:
> "Philip M. Gollucci" <pg...@p6m7g8.com> writes:
>>gmake:
>>	test
>>	docs
> 
> 
> You might be able to fix these though. test and docs 
> use gmake's "%.$ext" feature (cf. lines with "%.t" in 
> glue/perl/Makefile.PL and library/t/Makefile.am).
> 
> If you can rewrite those lines using more traditional
> Makefile conventions, we may be able to remove the
> gmake dependency (which would be a very good thing).
I'll definetley look at this; unfortunately probably not until next 
weekend though.  Can the FAQ.pod move to one of the pod dirs ?



-- 
END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com

Re: [PATCH[ Re: apre2 and httpd versions

Posted by Joe Schaefer <jo...@sunstarsys.com>.
"Philip M. Gollucci" <pg...@p6m7g8.com> writes:

[...]

> For reference:
>
> Make:
> 	all
> 	install
> 	docs_install
> 	clean
> 	docs_clean
> 	release
> 	test_release
>
> gmake:
> 	test
> 	docs

You might be able to fix these though. test and docs 
use gmake's "%.$ext" feature (cf. lines with "%.t" in 
glue/perl/Makefile.PL and library/t/Makefile.am).

If you can rewrite those lines using more traditional
Makefile conventions, we may be able to remove the
gmake dependency (which would be a very good thing).

-- 
Joe Schaefer


Re: [PATCH[ Re: apre2 and httpd versions

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
> Interestingly only the docs require gmake (make all test install)
> work with FreeBSD's make. On the plus side, the
> make docs gets much father :)
make test requires gmake as well.

That explains all my unneccary patches
to
RE: [PATCH] library/t/Makefile.am (all as one)

*sigh*

For reference:

Make:
	all
	install
	docs_install
	clean
	docs_clean
	release
	test_release

gmake:
	test
	docs


END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com

Re: [PATCH[ Re: apre2 and httpd versions

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
> Joe Schaefer wrote:
> 
>> "Philip M. Gollucci" <pg...@p6m7g8.com> writes:
>>> I'm hoping the correct fix is to prevenat make
>>> from cd'ing into modules/apache if you don't specify
>>> --with-apache1-apxs and only modules/apache2
>>>
>>> Thoughts ?
So sorry, I was using FreeBSD's make not gmake.

Interestingly only the docs require gmake (make all test install)
work with FreeBSD's make. On the plus side, the
make docs gets much father :)

If we're going to require it maybe we should check for it
upfront first ?

I read the warning in the STATUS file about using it
and it caused errors/warnings with my previous patch.

Here's one that works for FreeBSD's make and gmake

Attached.

END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com

[PATCH[ Re: apre2 and httpd versions

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Joe Schaefer wrote:
> "Philip M. Gollucci" <pg...@p6m7g8.com> writes:
> 
> [...]
> 
> 
>>I'm hoping the correct fix is to prevent make
>>from cd'ing into modules/apache if you don't specify
>>--with-apache1-apxs and only modules/apache2
>>
>>Thoughts ?
> 
> 
> +1.
> 
Patch attached.

END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com

Re: apre2 and httpd versions

Posted by Joe Schaefer <jo...@sunstarsys.com>.
"Philip M. Gollucci" <pg...@p6m7g8.com> writes:

[...]

> I'm hoping the correct fix is to prevent make
> from cd'ing into modules/apache if you don't specify
> --with-apache1-apxs and only modules/apache2
>
> Thoughts ?

+1.

-- 
Joe Schaefer


Re: apre2 and httpd versions -- SUCCESS!

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
>I probably missed this "install fix";
>Can you elaborate or direct me to the mailing list thread where it was
>discussed?
>
>Thanks,
>  
>
Hi,
Sure Archive -
http://marc.theaimsgroup.com/?l=apreq-dev&r=1&b=200504&w=2

The specific message in question is
http://marc.theaimsgroup.com/?l=apreq-dev&m=111355255305730&w=2

-- 
END
-----------------------------------------------------------------------------
Philip M. Gollucci
Senior Developer - Liquidity Services Inc.
Phone:  202.568.6268 (Direct)
E-Mail: pgollucci@liquidation.com
Web:    http://www.liquidation.com


Re: apre2 and httpd versions -- SUCCESS!

Posted by Eli Marmor <ma...@netmask.it>.
Great!

Philip M. Gollucci wrote:

> Given all the previous patches + the missing apache1/apache2 install fix
> (I hacked it temporarily).

I probably missed this "install fix";
Can you elaborate or direct me to the mailing list thread where it was
discussed?

Thanks,
-- 
Eli Marmor
marmor@netmask.it
Netmask (El-Mar) Internet Technologies Ltd.
__________________________________________________________
Tel.:   +972-9-766-1020          8 Yad-Harutzim St.
Fax.:   +972-9-766-1314          P.O.B. 7004
Mobile: +972-50-5237338          Kfar-Saba 44641, Israel

Re: apre2 and httpd versions -- SUCCESS!

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Hi,

Given all the previous patches + the missing apache1/apache2 install fix 
(I hacked it temporarily).

I'm pleased to say that _finally_ for apreq2
  *_ALL_ tests pass
  * it installs

with:
	perl 5.9.3 (rsync) w/OUT ithreads
	httpd-2.1.5-dev(trunk) apr is not threaded
	modperl2 1.999022 (trunk)
	FreeBSD6.0-current/i386 and libpthread.a

-- 
END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com