You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/01/02 05:46:23 UTC
Review Request 29539: Replaced Node with Address in Mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/
-----------------------------------------------------------
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca
src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
Diff: https://reviews.apache.org/r/29539/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 29539: Replaced Node with Address in Mesos.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Jan. 6, 2015, 2:36 p.m., Niklas Nielsen wrote:
> > src/master/contender.cpp, line 236
> > <https://reviews.apache.org/r/29539/diff/1/?file=805419#file805419line236>
> >
> > What guarantees that _url is a domain name? If that doesn't matter, then I don't understand the second argument to url().
This is being replaced by Cody's patches so I'm dropping.
> On Jan. 6, 2015, 2:36 p.m., Niklas Nielsen wrote:
> > src/master/detector.cpp, line 207
> > <https://reviews.apache.org/r/29539/diff/1/?file=805420#file805420line207>
> >
> > Same here.
Ditto (see above).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review66834
-----------------------------------------------------------
On Jan. 2, 2015, 4:46 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29539/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2015, 4:46 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
> src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
> src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
> src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca
> src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
> src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
>
> Diff: https://reviews.apache.org/r/29539/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 29539: Replaced Node with Address in Mesos.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review66834
-----------------------------------------------------------
One high-level question below, or else LGTM
src/master/contender.cpp
<https://reviews.apache.org/r/29539/#comment110491>
What guarantees that _url is a domain name? If that doesn't matter, then I don't understand the second argument to url().
src/master/detector.cpp
<https://reviews.apache.org/r/29539/#comment110492>
Same here.
- Niklas Nielsen
On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29539/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2015, 8:46 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
> src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
> src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
> src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca
> src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
> src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
>
> Diff: https://reviews.apache.org/r/29539/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 29539: Replaced Node with Address in Mesos.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review68974
-----------------------------------------------------------
src/master/contender.cpp
<https://reviews.apache.org/r/29539/#comment113533>
When was Etcd introduced? I followed the dependend patches chain and I don't see it.
- Timothy Chen
On Jan. 2, 2015, 4:46 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29539/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2015, 4:46 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
> src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
> src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
> src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca
> src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
> src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
>
> Diff: https://reviews.apache.org/r/29539/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 29539: Replaced Node with Address in Mesos.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Jan. 22, 2015, 9:29 p.m., Niklas Nielsen wrote:
> > To Tim's point - I don't see 'EtcdMasterContenderProcess' in the source base or in the patch chain?
> >
> > Otherwise, looks good but again, we need consensus on the address (or at least the naming) change.
I neglected to push the update for this, but the etcd code is removed from this patch now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review69267
-----------------------------------------------------------
On Jan. 2, 2015, 4:46 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29539/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2015, 4:46 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
> src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
> src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
> src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca
> src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
> src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
>
> Diff: https://reviews.apache.org/r/29539/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 29539: Replaced Node with Address in Mesos.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review69267
-----------------------------------------------------------
To Tim's point - I don't see 'EtcdMasterContenderProcess' in the source base or in the patch chain?
Otherwise, looks good but again, we need consensus on the address (or at least the naming) change.
- Niklas Nielsen
On Jan. 1, 2015, 8:46 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29539/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2015, 8:46 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
> src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406
> src/master/detector.cpp 700eb9dde8e71648bacc00a82766634f77cf2d15
> src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
> src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
> src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
> src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
> src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
> src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
> src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
> src/tests/gc_tests.cpp cb5dc5fa720bd2f344a9c7a3748dbe6f898705ca
> src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
> src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
> src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
>
> Diff: https://reviews.apache.org/r/29539/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 29539: Replaced Node with Address in Mesos.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/#review70140
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 28, 2015, 6:09 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29539/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 6:09 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
> src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
> src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
> src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
> src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
> src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6
> src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
> src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
> src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751
> src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
> src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
> src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
> src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
> src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
>
> Diff: https://reviews.apache.org/r/29539/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 29539: Replaced Node with Address in Mesos.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29539/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 2:09 a.m.)
Review request for mesos and Niklas Nielsen.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553
src/master/master.cpp e9dcca3c92c94f3123519855e238bcef47eeece9
src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2
src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268
src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9
src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6
src/tests/fetcher_tests.cpp 8c0b0757eb388f1684d8b94393983f1844a769a7
src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751
src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 678d27f41a2f246c714c77adb132263c0c2c61ed
src/tests/metrics_tests.cpp 7512b908ec1cbf80b74b768613a5f7925fa2249e
src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732
Diff: https://reviews.apache.org/r/29539/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman