You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/15 02:11:53 UTC
[GitHub] [cordova-android] erisu opened a new pull request #956: chore(npm):
add package-lock.json
erisu opened a new pull request #956: chore(npm): add package-lock.json
URL: https://github.com/apache/cordova-android/pull/956
### Motivation, Context & Description
Add `package-lock.json`
Requires #953, #954, #955
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #956: chore(npm):
add package-lock.json
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #956: chore(npm): add package-lock.json
URL: https://github.com/apache/cordova-android/pull/956#issuecomment-613798313
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=h1) Report
> Merging [#956](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/f86044e6ce207c40c5f876270528471a66e39557&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/956/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/956/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=footer). Last update [f86044e...b09db05](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #956:
chore(npm): add package-lock.json
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #956: chore(npm): add package-lock.json
URL: https://github.com/apache/cordova-android/pull/956#issuecomment-613798313
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=h1) Report
> Merging [#956](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/f86044e6ce207c40c5f876270528471a66e39557&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/956/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 65.53% 65.48% -0.06%
==========================================
Files 21 21
Lines 1828 1828
==========================================
- Hits 1198 1197 -1
- Misses 630 631 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/956/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.69% <0.00%> (-0.49%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=footer). Last update [f86044e...b09db05](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #956: chore(npm): add
package-lock.json
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #956: chore(npm): add package-lock.json
URL: https://github.com/apache/cordova-android/pull/956
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #956:
chore(npm): add package-lock.json
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #956: chore(npm): add package-lock.json
URL: https://github.com/apache/cordova-android/pull/956#issuecomment-613798313
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=h1) Report
> Merging [#956](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/f86044e6ce207c40c5f876270528471a66e39557&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/956/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 21 21
Lines 1828 1828
=======================================
Hits 1198 1198
Misses 630 630
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=footer). Last update [f86044e...b09db05](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #956:
chore(npm): add package-lock.json
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #956: chore(npm): add package-lock.json
URL: https://github.com/apache/cordova-android/pull/956#issuecomment-613798313
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=h1) Report
> Merging [#956](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/f86044e6ce207c40c5f876270528471a66e39557&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/956/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 21 21
Lines 1828 1828
=======================================
Hits 1198 1198
Misses 630 630
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=footer). Last update [f86044e...b09db05](https://codecov.io/gh/apache/cordova-android/pull/956?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org