[jira] [Commented] (THRIFT-2724) Coding standards page

["Randy Abernethy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303986#comment-14303986 ] 

Randy Abernethy commented on THRIFT-2724:
-----------------------------------------

Hey all,

This ticket is 6 months old and I can imagine it being 2 years old without all subtasks complete. Because it is a great idea I would like to see the sub tasks committed as they come in so that we can get the word out via the repo starting today (case in point: was trying to find Konrad's pep tester link and had to go to the github patch). This will also simplify incremental changes and open things up to public feedback.

+1 Roger's suggestion for integrating linters in every language build system to support the style guide where possible. If we can't type make && make check at the root and get a clean build on the reference platform we should not be committing it.

-Randy




> Coding standards page
> ---------------------
>
>                 Key: THRIFT-2724
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2724
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Konrad Grochowski
>         Attachments: coding_standards.patch
>
>
> it would be nice to have some basic coding standards for all langs used by thrift, especially those that do not come with 'built-in' standards.
> I'm suggesting some simple, short guidelines, just to help contributors prepare good patch
> preferably: new doc in docs folder, linked from doc/contributing.md



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)