[GitHub] [incubator-druid] drcrallen commented on a change in pull request #7273: Fix some IntelliJ inspections

[GitBox <gi...@apache.org>]

drcrallen commented on a change in pull request #7273: Fix some IntelliJ inspections
URL: https://github.com/apache/incubator-druid/pull/7273#discussion_r266123803
 
 

 ##########
 File path: extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
 ##########
 @@ -246,15 +246,14 @@ static String typeStringFromParseSpec(ParseSpec parseSpec)
     builder.append(parseSpec.getTimestampSpec().getTimestampColumn()).append(":string");
     // the typeString seems positionally dependent, so repeated timestamp column causes incorrect mapping
     if (parseSpec.getDimensionsSpec().getDimensionNames().size() > 0) {
-      builder.append(",");
-      builder.append(String.join(
 
 Review comment:
   non germane change?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org