You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/08 08:58:13 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4657: Use ProjectionsContext to process QueryHeader on proxy
terrymanu opened a new pull request #4657: Use ProjectionsContext to process QueryHeader on proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/4657
For #4637.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4657: Use ProjectionsContext to process QueryHeader on proxy
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4657: Use ProjectionsContext to process QueryHeader on proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/4657#issuecomment-596183870
## Pull Request Test Coverage Report for [Build 2026](https://coveralls.io/builds/29204375)
* **9** of **19** **(47.37%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.2%**) to **59.128%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/callback/ProxySQLExecuteCallback.java](https://coveralls.io/builds/29204375/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fcallback%2FProxySQLExecuteCallback.java#L63) | 0 | 10 | 0.0%
<!-- | **Total:** | **9** | **19** | **47.37%** | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/29204375/badge)](https://coveralls.io/builds/29204375) |
| :-- | --: |
| Change from base [Build 1018](https://coveralls.io/builds/29204233): | 0.2% |
| Covered Lines: | 12129 |
| Relevant Lines: | 20513 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4657:
Use ProjectionsContext to process QueryHeader on proxy
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4657: Use ProjectionsContext to process QueryHeader on proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/4657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4657: Use
ProjectionsContext to process QueryHeader on proxy
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4657: Use ProjectionsContext to process QueryHeader on proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/4657#issuecomment-596183870
## Pull Request Test Coverage Report for [Build 10108](https://coveralls.io/builds/29204357)
* **9** of **19** **(47.37%)** changed or added relevant lines in **2** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.1%**) to **59.05%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/callback/ProxySQLExecuteCallback.java](https://coveralls.io/builds/29204357/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fcallback%2FProxySQLExecuteCallback.java#L63) | 0 | 10 | 0.0%
<!-- | **Total:** | **9** | **19** | **47.37%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29204357/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/29204357/badge)](https://coveralls.io/builds/29204357) |
| :-- | --: |
| Change from base [Build 1018](https://coveralls.io/builds/29204233): | 0.1% |
| Covered Lines: | 12113 |
| Relevant Lines: | 20513 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4657: Use
ProjectionsContext to process QueryHeader on proxy
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4657: Use ProjectionsContext to process QueryHeader on proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/4657#issuecomment-596183578
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657?src=pr&el=h1) Report
> Merging [#4657](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/5ecf56a03e6a3306c3803ead13299ec3f30b18f9?src=pr&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `42.1%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4657 +/- ##
============================================
+ Coverage 55.36% 55.49% +0.13%
Complexity 426 426
============================================
Files 1134 1134
Lines 20547 20513 -34
Branches 3811 3805 -6
============================================
+ Hits 11376 11384 +8
+ Misses 8453 8412 -41
+ Partials 718 717 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../communication/jdbc/execute/JDBCExecuteEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRlL0pEQkNFeGVjdXRlRW5naW5lLmphdmE=) | `33.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9KREJDRGF0YWJhc2VDb21tdW5pY2F0aW9uRW5naW5lLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...jdbc/execute/callback/ProxySQLExecuteCallback.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRlL2NhbGxiYWNrL1Byb3h5U1FMRXhlY3V0ZUNhbGxiYWNrLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rdingproxy/backend/response/query/QueryHeader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3Jlc3BvbnNlL3F1ZXJ5L1F1ZXJ5SGVhZGVyLmphdmE=) | `84.61% <88.88%> (+30.76%)` | `0 <0> (ø)` | :arrow_down: |
| [...ql/segment/dml/item/SubqueryProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9TdWJxdWVyeVByb2plY3Rpb25TZWdtZW50LmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [.../sql/parser/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...segment/dml/item/AggregationProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9BZ2dyZWdhdGlvblByb2plY3Rpb25TZWdtZW50LmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [.../sql/segment/dml/item/ColumnProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9Db2x1bW5Qcm9qZWN0aW9uU2VnbWVudC5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...dml/item/AggregationDistinctProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9BZ2dyZWdhdGlvbkRpc3RpbmN0UHJvamVjdGlvblNlZ21lbnQuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...phere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvaW1wbC9NeVNRTERNTFZpc2l0b3IuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657?src=pr&el=footer). Last update [5ecf56a...219a579](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4657?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services