You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Freeman Fang (JIRA)" <ji...@apache.org> on 2010/12/15 12:31:05 UTC
[jira] Created: (CXF-3192) extract GZIP Interceptors/Feature from
http transport to rt-core
extract GZIP Interceptors/Feature from http transport to rt-core
----------------------------------------------------------------
Key: CXF-3192
URL: https://issues.apache.org/jira/browse/CXF-3192
Project: CXF
Issue Type: Task
Reporter: Freeman Fang
Assignee: Freeman Fang
Fix For: 2.3.2, 2.4
currently GZIPInInterceptor/GZIPOutInterceptor/GZIPFeature are in http transport module, as we're going to support gzip encoding over JMS transport also, we need extract those classes to upper rt-core module so that we can use it from different transports.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-3192) extract GZIP Interceptors/Feature from
http transport to transport-common module
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved CXF-3192.
-------------------------------
Resolution: Fixed
commit fix
http://svn.apache.org/viewvc?rev=1049783&view=rev for trunk
http://svn.apache.org/viewvc?rev=1049790&view=rev for 2.3 branch
> extract GZIP Interceptors/Feature from http transport to transport-common module
> --------------------------------------------------------------------------------
>
> Key: CXF-3192
> URL: https://issues.apache.org/jira/browse/CXF-3192
> Project: CXF
> Issue Type: Task
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.3.2, 2.4
>
>
> currently GZIPInInterceptor/GZIPOutInterceptor/GZIPFeature are in http transport module, as we're going to support gzip encoding over JMS transport also, we need extract those classes to upper rt-core module so that we can use it from different transports.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (CXF-3192) extract GZIP Interceptors/Feature
from http transport to rt-core
Posted by Sergey Beryozkin <sb...@gmail.com>.
Hi Freeman
On Wed, Dec 15, 2010 at 12:03 PM, Freeman Fang <fr...@gmail.com>wrote:
> Hi Sergey,
>
> Somehow I can't find your comment from CXF-3192, so I just reply here
> directly :-).
>
Sorry, it must've been lost as out network connection is unstable at the
moment
> Yeah, we already have Attachemt related interceptors in
> ./rt/core/src/main/java/org/apache/cxf/interceptor/, and how about we put
> GZIPIn/OutInterceptor in
> ./rt/core/src/main/java/org/apache/cxf/transport/interceptor folder?
> I just don't wanna introduce a new rt-transports-core module to host GZIP
> interceptors.
> WDYT?
>
>
I kind of feel that there's a line there we may not want to cross :-). See
the AttachmentInterceptors have been there for ages but one can even argue
that an Attachment is not exactly a transport-specific term, it can be a
hypothetical argument :-), but still... GZIP has so much 'HTTP' all over it,
though I agree that using a GZIP compression technique should be possible
for other transports too, why not.
Yes, rt-transports-core would host only GZIP related interceptors/feature
for a start but what if if we moved the attachment interceptors there too,
say for 2.4.0 only ? And perhaps we can see more interceptors added there in
time ?
cheers, Sergey
Best Regards
> Freeman
> On 2010-12-15, at 下午7:39, Sergey Beryozkin (JIRA) wrote:
>
>
>> [
>> https://issues.apache.org/jira/browse/CXF-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971629#action_12971629]
>>
>> Sergey Beryozkin commented on CXF-3192:
>> ---------------------------------------
>>
>> Hi Freeman - is it really a core-level feature ? I'd vote for introducing
>> a rt-transports-core. I guess we do have attachments related interceptors in
>> the core but having GZIP-related interceptors there just seems a bit unusual
>>
>> cheers, Sergey
>>
>> extract GZIP Interceptors/Feature from http transport to rt-core
>>> ----------------------------------------------------------------
>>>
>>> Key: CXF-3192
>>> URL: https://issues.apache.org/jira/browse/CXF-3192
>>> Project: CXF
>>> Issue Type: Task
>>> Reporter: Freeman Fang
>>> Assignee: Freeman Fang
>>> Fix For: 2.3.2, 2.4
>>>
>>>
>>> currently GZIPInInterceptor/GZIPOutInterceptor/GZIPFeature are in http
>>> transport module, as we're going to support gzip encoding over JMS transport
>>> also, we need extract those classes to upper rt-core module so that we can
>>> use it from different transports.
>>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
> --
> Freeman Fang
>
> ------------------------
>
> FuseSource: http://fusesource.com
> blog: http://freemanfang.blogspot.com
> twitter: http://twitter.com/freemanfang
> Apache Servicemix:http://servicemix.apache.org
> Apache Cxf: http://cxf.apache.org
> Apache Karaf: http://karaf.apache.org
> Apache Felix: http://felix.apache.org
>
>
Re: [jira] Commented: (CXF-3192) extract GZIP Interceptors/Feature from http transport to rt-core
Posted by Freeman Fang <fr...@gmail.com>.
Hi Sergey,
Somehow I can't find your comment from CXF-3192, so I just reply here
directly :-).
Yeah, we already have Attachemt related interceptors in ./rt/core/src/
main/java/org/apache/cxf/interceptor/, and how about we put GZIPIn/
OutInterceptor in ./rt/core/src/main/java/org/apache/cxf/transport/
interceptor folder?
I just don't wanna introduce a new rt-transports-core module to host
GZIP interceptors.
WDYT?
Best Regards
Freeman
On 2010-12-15, at 下午7:39, Sergey Beryozkin (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/CXF-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971629
> #action_12971629 ]
>
> Sergey Beryozkin commented on CXF-3192:
> ---------------------------------------
>
> Hi Freeman - is it really a core-level feature ? I'd vote for
> introducing a rt-transports-core. I guess we do have attachments
> related interceptors in the core but having GZIP-related
> interceptors there just seems a bit unusual
>
> cheers, Sergey
>
>> extract GZIP Interceptors/Feature from http transport to rt-core
>> ----------------------------------------------------------------
>>
>> Key: CXF-3192
>> URL: https://issues.apache.org/jira/browse/CXF-3192
>> Project: CXF
>> Issue Type: Task
>> Reporter: Freeman Fang
>> Assignee: Freeman Fang
>> Fix For: 2.3.2, 2.4
>>
>>
>> currently GZIPInInterceptor/GZIPOutInterceptor/GZIPFeature are in
>> http transport module, as we're going to support gzip encoding over
>> JMS transport also, we need extract those classes to upper rt-core
>> module so that we can use it from different transports.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
--
Freeman Fang
------------------------
FuseSource: http://fusesource.com
blog: http://freemanfang.blogspot.com
twitter: http://twitter.com/freemanfang
Apache Servicemix:http://servicemix.apache.org
Apache Cxf: http://cxf.apache.org
Apache Karaf: http://karaf.apache.org
Apache Felix: http://felix.apache.org
[jira] Commented: (CXF-3192) extract GZIP Interceptors/Feature from
http transport to rt-core
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971629#action_12971629 ]
Sergey Beryozkin commented on CXF-3192:
---------------------------------------
Hi Freeman - is it really a core-level feature ? I'd vote for introducing a rt-transports-core. I guess we do have attachments related interceptors in the core but having GZIP-related interceptors there just seems a bit unusual
cheers, Sergey
> extract GZIP Interceptors/Feature from http transport to rt-core
> ----------------------------------------------------------------
>
> Key: CXF-3192
> URL: https://issues.apache.org/jira/browse/CXF-3192
> Project: CXF
> Issue Type: Task
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.3.2, 2.4
>
>
> currently GZIPInInterceptor/GZIPOutInterceptor/GZIPFeature are in http transport module, as we're going to support gzip encoding over JMS transport also, we need extract those classes to upper rt-core module so that we can use it from different transports.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-3192) extract GZIP Interceptors/Feature from
http transport to rt-core
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971666#action_12971666 ]
Freeman Fang commented on CXF-3192:
-----------------------------------
More discussion from mailing list[1]
[1]http://cxf.547215.n5.nabble.com/Re-jira-Commented-CXF-3192-extract-GZIP-Interceptors-Feature-from-http-transport-to-rt-core-td3306151.html
After discussion with Sergey, we plan to introduce a new module as rt/transports/common, and put gzip related stuff in this module, and make cxf-rt-transports-jms and cxf-rt-transports-http depend on cxf-rt-transports-common
> extract GZIP Interceptors/Feature from http transport to rt-core
> ----------------------------------------------------------------
>
> Key: CXF-3192
> URL: https://issues.apache.org/jira/browse/CXF-3192
> Project: CXF
> Issue Type: Task
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.3.2, 2.4
>
>
> currently GZIPInInterceptor/GZIPOutInterceptor/GZIPFeature are in http transport module, as we're going to support gzip encoding over JMS transport also, we need extract those classes to upper rt-core module so that we can use it from different transports.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-3192) extract GZIP Interceptors/Feature from
http transport to transport-common module
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated CXF-3192:
------------------------------
Summary: extract GZIP Interceptors/Feature from http transport to transport-common module (was: extract GZIP Interceptors/Feature from http transport to rt-core)
> extract GZIP Interceptors/Feature from http transport to transport-common module
> --------------------------------------------------------------------------------
>
> Key: CXF-3192
> URL: https://issues.apache.org/jira/browse/CXF-3192
> Project: CXF
> Issue Type: Task
> Reporter: Freeman Fang
> Assignee: Freeman Fang
> Fix For: 2.3.2, 2.4
>
>
> currently GZIPInInterceptor/GZIPOutInterceptor/GZIPFeature are in http transport module, as we're going to support gzip encoding over JMS transport also, we need extract those classes to upper rt-core module so that we can use it from different transports.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.