[GitHub] [netbeans] lbownik commented on a diff in pull request #5802: Improving enable-preview Java fix

["lbownik (via GitHub)" <gi...@apache.org>]

lbownik commented on code in PR #5802:
URL: https://github.com/apache/netbeans/pull/5802#discussion_r1168260760


##########
java/ant.hints/src/org/netbeans/modules/ant/hints/errors/EnablePreviewAntProj.java:
##########
@@ -195,7 +166,7 @@ public EditableProperties run() throws IOException {
         }
     }
 
-    private boolean isAntProject(Project prj) {
+    private static boolean isAntProject(Project prj) {
         if (prj == null) {

Review Comment:
   wen methods become NOPs when given improper arguments it gets harder to reason about program flow
   just my 0.02$



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists